NioTlsMessageChannel tries to parse TLS_CLIENT_PROTOCOLS on its own and fails

[GoogleCodeExporter]

See

http://code.google.com/p/jain-sip/issues/detail?id=56#c6

I have reproduced.

Issue is that NioTlsMessageChannel.init() tries to parse TLS_CLIENT_PROTOCOLS 
setting instead of relying on (wisest) SipStackImpl parsing.

Original issue reported on code.google.com by josemre...@gmail.com on 4 Apr 2013 at 6:22

[GoogleCodeExporter]

Attached proposed patch. Changes in two files:

- SipStackImpl: character " as a valid tokenizer to parse TLS_CLIENT_PROTOCOLS

- NioTlsMessageChannel relies on SipStackImpl parsing instead of parsing on its 
own

With this patch, all these options are accepted and processed:

gov.nist.javax.sip.TLS_CLIENT_PROTOCOLS = SSLv3, TLSv1

gov.nist.javax.sip.TLS_CLIENT_PROTOCOLS = SSLv3 TLSv1

gov.nist.javax.sip.TLS_CLIENT_PROTOCOLS = "SSLv3, TLSv1"

Original comment by josemre...@gmail.com on 4 Apr 2013 at 7:16

Attachments:

• patch.issue.93.patch

[GoogleCodeExporter]

Original comment by jean.der...@telestax.com on 18 Apr 2013 at 1:36

• Changed state: Accepted
• Added labels: Component-JAIN-SIP, TelScale-6.1.3.GA

[GoogleCodeExporter]

This issue was updated by revision a41872a300f5.

Issue 451
JAIN SIP Repo

Fix + non regression tests

git-svn-id: https://svn.java.net/svn/jsip~svn/trunk@2279 
8e71dc83-d81e-6649-80f2-80b843a9b2be

Original comment by jean.deruelle on 18 Apr 2013 at 3:11

[GoogleCodeExporter]

Original comment by jean.der...@telestax.com on 18 Apr 2013 at 3:15

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by jean.deruelle on 13 Jun 2013 at 8:13

• Added labels: Type-Defect

[GoogleCodeExporter]

This issue was updated by revision f63101b69403.

Backport to TelScale

Issue 451
JAIN SIP Repo

Fix + non regression tests
(cherry picked from commit e270bd4ed248c5335d73c0ee017976a04433f4d6)

Conflicts:
    src/test/unit/gov/nist/javax/sip/stack/tls/Shootist.java

Original comment by jean.der...@telestax.com on 19 Aug 2014 at 4:59