search

showtime-xyz / showtime-tab-view

A react native TabView component that support collapse header and custom refresh control, powered by Reanimated & GestureHandler. Join Showtime:
https://showtime-xyz.notion.site/Join-Showtime-Public-fa6282938e284134b302184062d7e329
MIT License
219 stars 23 forks source link

chore: move `dependencies` to `devDependencies` #15

Closed Stringsaeed closed 1 year ago

Stringsaeed commented 1 year ago

Problem

Many react-native projects already have reanimated and gesture-handler installed as dependencies. However, when installing @showtime-xyz/tab-view, it installs another version of these packages, leading to multiple versions being installed within the same project. This situation arises because the package does not make use of the peerDependencies feature provided by the package manager.

Solution

This PR proposes a simple solution by moving the peer dependencies from the dependencies section to the devDependencies section in the package.json file. This adjustment ensures that the package manager does not reinstall different versions of the same packages unnecessarily, avoiding conflicts and potential compatibility issues.

alantoa commented 1 year ago

thank you very much! @Stringsaeed LGTM! 🙏