shpaass / yafc-ce

Powerful Factorio calculator/analyser that works with mods
GNU General Public License v3.0
40 stars 15 forks source link

Draw smaller icons over variable backgrounds. #144

Closed DaleStan closed 1 month ago

DaleStan commented 1 month ago

This adds a new preference (and alters the UI for an existing one) to allow you to choose how much to scale down certain icons: image The default is 90%, which is the middle size in this gif. The other two sizes shown are 80% and 100%; 100% shows the issue where the background color is not visible, hiding the link information. Untitled

The Desired products, Summary ingredients, and Extra products icons all scale too.

Potential additions and/or reversions

The SelectMultiObjectPanel icons used to be fixed at 80%, but I chose to make them follow this setting too. The SelectSingleObjectPanel, icons were also fixed at 80%, but I just bumped them up to 100%, since they never have an interesting background. I can restore one or both SelectObjectPanel behaviors, or make SelectSingleObjectPanel follow this setting for consistency. I can also extend the scaling to the recipe, entity, module, and/or beacon icons. I actually originally had the entity icon scale, but I saw how small the small assembler is (the crafter for Electrical engineering research 2) and decided I didn't want to make it even smaller.

shpaass commented 1 month ago

Just to clarify, you introduce this feature because you yourself use it, right? Not that I'm against it, just checking.
I would be against it if it was added when you did not use it yourself, because then we'd need to check if someone would use it at all.

veger commented 1 month ago

I would/will set the scale to 90% myself, as those colors convey (important) information and are sometimes impossible/hard to see.

shpaass commented 1 month ago

Ah, I see. The gif shows an example in Pysics Research Unboxing.