search

shpasser / GaeSupportL5

Google App Engine Support package for Laravel 5
MIT License
160 stars 27 forks source link

allowing to specify sender #49

Closed myownsumm closed 8 years ago

myownsumm commented 8 years ago

GAE is allowing to specify custom email senders listed in project settings.

myownsumm commented 8 years ago

@shpasser are there any problems with the code to accept the pull request?

shpasser commented 8 years ago

Yep, the documentation has to be updated accordingly, and even then will have to test the change and choose the right approach to incorporate it.

shpasser commented 8 years ago

Additionally $message->getSender() returns a string according to Swift Mailer documentation.

myownsumm commented 8 years ago

@shpasser but in fact it is an array.

shpasser commented 8 years ago

Indeed you are correct. Please notice that sender field has to be defined when the message contains more than one address in its from field, meaning the sender field is not mandatory. As you can see it is very important to explore the possible uses of the feature and test it before I will be able to accept the pull request. Please do not forget to update the readme file.

shpasser commented 8 years ago

@myownsumm are you in?

shpasser commented 8 years ago

Hi @myownsumm, I'm going to wait for 3 more days for your decision. If I do not have your answer by then I'll have to decide if I'm going to implement the feature or close the request.