search

shpp / programming.org.ua

https://programming.org.ua/
0 stars 1 forks source link

update links in translations for each language #32

Closed ihor-bobyr closed 1 year ago

ihor-bobyr commented 1 year ago

for example

Screenshot 2023-04-09 at 04 19 31
k-boiko commented 1 year ago

I can update this in JSON for translations, so text will be like "We teach programming for free everybody".... etc However, current JSON is used in production, so I can either create new records in JSON or we need to wait for this fix until release.

ihor-bobyr commented 1 year ago

I can update this in JSON for translations, so text will be like "We teach programming for free everybody".... etc However, current JSON is used in production, so I can either create new records in JSON or we need to wait for this fix until release.

separate keys (with some specific name for later refactoring) looks good for me)

ihor-bobyr commented 1 year ago

отправила доступ https://www.notion.so/shpp/programming-org-ua-translations-9a24c687dd8b4218a7487272454ee852?pvs=4 те ключи, что я добавила, заканчиваются на суфикс _new в таблице вы видите три колонки для каждого языка, содержимое колонки будет в виде строки в джсоне вы можете менять прям в таблице и в строку инджектить такие переменные как вам нужно, например

\ text

вверху страницы в ноушне есть ссылка для сохранения изменений

ну и прошу быть осторожным, это же прод)) дев версии у нас нет увы

k-boiko commented 1 year ago

I updated all links, no code changes were needed, and it didn't impact the production too, so I removed unnecessary records with suffix "_new" in JSON. Issue might be resolved now, @ihor-bobyr can you please take a look?

ihor-bobyr commented 1 year ago

looks like problems with links were solved for index page, so I will close this issue