shprink / ionic-native-transitions

[Maintenance only] Native transitions (iOS & Android) for Ionic Framework

https://www.npmjs.com/package/ionic-native-transitions

MIT License

572 stars 112 forks source link

Fixing overlapping/flickering of current view when navigating (#121) #137

Closed heekinho closed 7 years ago

heekinho commented 7 years ago

It seems the transition is sometimes faster than the plugin can take the screenshot. The requests were asyncronous: plugin action wasn't a blocking call, so the state change happened immediately.

I changed the callbacks into promises using $q and in the every transition() call I chain the state change, so that only happens after the screenshot.

125 #121 #108 #78 #77

kenmickles commented 7 years ago

This looks good! I'll test and merge later this week.