shprink / ionic-native-transitions

[Maintenance only] Native transitions (iOS & Android) for Ionic Framework
https://www.npmjs.com/package/ionic-native-transitions
MIT License
572 stars 112 forks source link

-1 is not applied for back transition #24

Open tbro028 opened 8 years ago

tbro028 commented 8 years ago

Samsung S5, not using crosswalk, 0.5.4 of npm telerik plugin

-1 delay is working great but when moving 'back', the transition is immediate without waiting for page to load, so the same page starts transitioning before flicking over to the new page. Not sure if it is this plugin or telerik plugin issue.

shprink commented 8 years ago

That's weird, I will have to try it out.

NgYueHong commented 8 years ago

@tbro028 Could it be the issue of ionic event executes inaccurate? I personally found about this issue (https://github.com/shprink/ionic-native-transitions/issues/23). Try remove $ionicConfig.views.transition('none') in this plugin or have your own to override it. Let me know if this help.

shprink commented 8 years ago

On the develop branch you can enable ionic transitions. They are disable by default. but you couyld call this on you .run:

    /**
     * @ngdoc function
     * @name ionic-native-transitions.$ionicNativeTransitions#enable
     * @access public
     * @methodOf ionic-native-transitions.$ionicNativeTransitions
     *
     * @description
     * enable/disable plugin
     * @param {boolean} enabled
     * @param {boolean} disableIonicTransitions
     * @param {string}  ionicTransitionType
     */
$ionicNativeTransitions.enable(true, false);
tbro028 commented 8 years ago

$ionicNativeTransitions.enable(true, false); setting this caused my app to crash at startup, haven't been able to debug because at work, but when removed the above and set $ionicConfig.views.transition('platform'), app starts but flicker still exists ( ihave nav-transition="false" on my side-menu items) Will try do some more debugging later.

shprink commented 8 years ago

Ok thanks, let me know what you find

tbro028 commented 8 years ago

i've applied:

$ionicNativeTransitions.enable(true, false);

nav-transition on my menu items

using the default options

still got flicker for transitions with more than a few elements

maybe I need to use crosswalk? waiting for pgb to allow crosswalkanimatable

On Mon, Nov 9, 2015 at 1:45 PM, Julien Renaux notifications@github.com wrote:

Ok thanks, let me know what you find

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/24#issuecomment-154892448 .

giugrilli commented 8 years ago

I have the same problem (maybe)

It happens every time I hit back to go to the back view (with or without crosswalk, with or without "$ionicNativeTransitions.enable(true, false)"): the native transition starts, but the view visualized as back page during the transition is the current one! Then it changes to the actual back view (sometimes at half the transition, somethimes at the end). The effect is not so good.

shprink commented 8 years ago

what versions do you use?

giugrilli commented 8 years ago

-cordova plugin version com.telerik.plugins.nativepagetransitions 0.5.5 "Native Page Transitions" -ionic-native-transitions.js version: v1.0.0-rc1

shprink commented 8 years ago

ok great, I will have a look, in the meantime if you have any idea how to fix that, PR are welcome :)

shprink commented 8 years ago

I have tested I cannot reproduce. Can you share your app apk in debug mode please?

tbro028 commented 8 years ago

Problem for me seems to happen when images are present. Will update your new version and make sure my images are not scaled at all and see if that works

On Thu, Nov 19, 2015 at 6:14 PM, Julien Renaux notifications@github.com wrote:

I have tested I cannot reproduce. Can you share your app apk in debug mode please?

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/24#issuecomment-157953041 .

danielptn commented 8 years ago

same problem.. happens when image are present too.. someone have solution?