search

shprink / ionic-native-transitions

[Maintenance only] Native transitions (iOS & Android) for Ionic Framework
https://www.npmjs.com/package/ionic-native-transitions
MIT License
572 stars 112 forks source link

RC testing #25

Open shprink opened 8 years ago

shprink commented 8 years ago

Guys, I have released v1.0.0-rc1 with your requested features:

Can you check if it is all good for you? If I do not have negative feedback I will release v1.0.0 :)

@hlehmann @leobetosouza @mabdelfattah @NgYueHong

PS: Do not forget to use the telerik plugin v.0.5.4

NgYueHong commented 8 years ago

@shprink Wow, Great work and big improvement update!! I really like the new stateGo, locationUrl and the directive feature. I am looking for it as well.

However, here I would like to ask for adding back pendingTransitionDelay setting which was once introduced before. Yeah, having that settings may sound stupid as we now have full control when to animate it. But I wish to have that setting as optional and able to apply on certain state / page. Because there are still cases where we might need to have some extra small delay on heavy pages to have smoother and better transition on slow devices.

shprink commented 8 years ago

Yeah I could add it back.

NgYueHong commented 8 years ago

@shprink Can we have custom triggerTransitionEvent on certain state? If can be done, maybe can document it.

shprink commented 8 years ago

It is not possible right now but I guess it is technically possible.

tbro028 commented 8 years ago

A nice feature might be to have the 'back' button do the opposite of the what was used to enter the view.

If the page was slide left to enter, back could be slide right, if it was slide up, slide down, flip --> flip... etc etc

shprink commented 8 years ago

Yeah but you can already set default back and forward transitions @tbro028

NgYueHong commented 8 years ago

@shprink I guess what @tbro028 mean is to have a function that will automatically do opposite transition. For example if this is the series of animation I go through when enter to next page: slide right, slide right, slide up, fade in

Then, if now I continuously hit the back button, it would be: fade out, slide down, slide left, slide left

It maybe hard to have it to be automatically, but maybe enable us to manually set custom back animation for certain page?

tbro028 commented 8 years ago

exactly, because i slide into my menu items I want to slide right back out. Thats fine, but on one of those pages i have a button which flips to a page, i'd like to be able to flip back out of it. Likewise I have a button which slides up a page, i'd like to slide that back down like a modal if they want to exit it

shprink commented 8 years ago

but maybe enable us to manually set custom back animation for certain page?

I could add that that's a great feature to have.

Also I could add the automatic opposite back transition. I do not think it is complecated. Thanks for sharing those use cases guys :)

shprink commented 8 years ago

Apparently there is a bug on iOS swipe back #26 Need to test

shprink commented 8 years ago

Anyone else is having #24 issue?

shprink commented 8 years ago

Rc2 is out with now the ability for the hardware back button to close modal, menu or action sheet if open instead of transitioning back. #32

It mimics the actual ionic behaviour.

NgYueHong commented 8 years ago

How 'bout custom triggerTransitionEvent?

shprink commented 8 years ago

Sorry, I forgot @NgYueHong

shprink commented 8 years ago

36 @NgYueHong

shprink commented 8 years ago

R3 released.

tbro028 commented 8 years ago

Quick test. Opposite back doesn't work on hardware back button. App btn ok. On 19/11/2015 7:24 pm, "Julien Renaux" notifications@github.com wrote:

R3 released.

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/25#issuecomment-157962979 .

shprink commented 8 years ago

@tbro028 are you using crosswalk? I have no problem with it.

tbro028 commented 8 years ago

No, will try crosswalk and let you know On 20/11/2015 8:20 pm, "Julien Renaux" notifications@github.com wrote:

@tbro028 https://github.com/tbro028 are you using crosswalk? I have no problem with it.

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/25#issuecomment-158307079 .

tbro028 commented 8 years ago

Same problem in the 1.4.0 version of pgb-adapt crosswalk plugin. Which is using xwalk 15 but def not the latest version as it has the keyboard flicker.

On Sat, Nov 21, 2015 at 11:11 AM, Tim Broadhurst timbroadhurst@gmail.com wrote:

No, will try crosswalk and let you know On 20/11/2015 8:20 pm, "Julien Renaux" notifications@github.com wrote:

@tbro028 https://github.com/tbro028 are you using crosswalk? I have no problem with it.

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/25#issuecomment-158307079 .

shprink commented 8 years ago

v1.0.0-rc4 is out. it attempts to fix #39

Let me know @tbro028

tbro028 commented 8 years ago

rc5 working for #39!!!!!!!!!!!!

On Fri, Dec 4, 2015 at 6:46 AM, Julien Renaux notifications@github.com wrote:

v1.0.0-rc4 is out. it attempts to fix #39 https://github.com/shprink/ionic-native-transitions/issues/39

Let me know @tbro028 https://github.com/tbro028

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/25#issuecomment-161728386 .

shprink commented 8 years ago

Awesome, I guess only the ios swipe back is missing for the stable release. If any of you have any idea how we can simply do that please comment on #41

shprink commented 8 years ago

Guys can you reproduce this: #47 ?

For me when I hit the back button on Android it closes the app if there is no more history.

shprink commented 8 years ago

RC6 is released!

https://github.com/shprink/ionic-native-transitions/blob/develop/CHANGELOG.md#100-rc6

tbro028 commented 8 years ago

I had the problem, but I wanted to have a popup to confirm if user wanted to exit the app so I override the hardware back button and implement my own exit strategy so it's no longer an issue.

On Sat, Dec 19, 2015 at 4:31 AM, Julien Renaux notifications@github.com wrote:

Guys can you reproduce this: #47 https://github.com/shprink/ionic-native-transitions/issues/47

For me when I hit the back button on Android it closes the app if there is no more history.

— Reply to this email directly or view it on GitHub https://github.com/shprink/ionic-native-transitions/issues/25#issuecomment-165805600 .

michaeldisaro commented 8 years ago

I just tried the plugin, when I tap on the button to change the state the transition works well.

The problem is that it's also triggering the datepicker opening on the next view because the datepicker it's on the same position of the button in the previous page.

The result is that I arrive on the page with the datepicker already opened like I had tapped on it.

Do i miss something in configuration?

shprink commented 8 years ago

@michaeldisaro there is a ticket for that => https://github.com/shprink/ionic-native-transitions/issues/70

michaeldisaro commented 8 years ago

Sorry I did not see that. I'm not a native android developer, but looking in the code made me think about the fact that you are pre-creating a ViewGroup during init with some pre-rendered views on which you do animations. The default behaviour of view group, I think (excuse me if I'm wrong, you surely got more experience than me with android), is that it propagates touch events to all its childs if you do not override onInterceptTouchEvent() properly. That may be the reason why a touch also triggers event on next view.

shprink commented 8 years ago

@michaeldisaro maybe that something you want to ask @EddyVerbruggen the creator of the cordova plugin https://github.com/Telerik-Verified-Plugins/NativePageTransitions

michaeldisaro commented 8 years ago

Yes, you're right, you just made the ionic integration.