shprink / ionic-native-transitions

[Maintenance only] Native transitions (iOS & Android) for Ionic Framework
https://www.npmjs.com/package/ionic-native-transitions
MIT License
572 stars 113 forks source link

Incompatible with Admobs #48

Open Shinzah opened 8 years ago

Shinzah commented 8 years ago

I have an issue when using AdMobs and Native Transitions. For the first page, all work fine.

screenshot_2015-12-17-12-12-02

But when i change page, the ad go to the top of the screen, the previous page is in the center of the page, and the new page is behind the previous page (crazy !!) screenshot_2015-12-17-12-12-20

Shinzah commented 8 years ago

Note that it only append when using AdMob.AD_POSITION.BOTTOM_CENTER options in AdMob

shprink commented 8 years ago

Interesting. If you disable this plugin does it work correctly?

Shinzah commented 8 years ago

Yes, if i disable the NativeTransition plugin, it work fine. If using the AdMob.AD_POSITION.TOP_CENTER, all work fine. (The add stay in top, and the page content is correct)

shprink commented 8 years ago

@EddyVerbruggen do you think it is related to this plugin? Have you tested your plugin with admobs?

Thanks

EddyVerbruggen commented 8 years ago

Nope, I can't possibly test all plugins with all other plugins ;) But I can imagine the fact that the webview is pushed up by admob will interfere with the transitions plugin.

Can you post how you're using the plugin? Slide with fixedPixelsBottom perhaps?

Shinzah commented 8 years ago

I only use

$ionicNativeTransitions.enable(true);

Without any other configuration.

And for admobs :

$cordovaGoogleAds.createBanner({
                        adId: banner_id,
                        position: AdMob.AD_POSITION.BOTTOM_CENTER,
                        autoShow: false
                    }).then(function() {
                        _bannerCreated = true;
                        $cordovaGoogleAds.showBanner(AdMob.AD_POSITION.BOTTOM_CENTER);
                    });
degroundshaker commented 8 years ago

I came up with the same issue.

I solved it by setting overlap parameter to true

shprink commented 8 years ago

Awesome @Shinzah what to try to see if it solves your problem? If it does please close this ticket

degroundshaker commented 8 years ago

@shprink For me, it did 100.1% :)

Shinzah commented 8 years ago

Hi, Indeed it works with native transition, but the problem is the "overlap" ... which ... well, overlap the bottom of the screen. And because of the device size, the height is not always the same, so i can't add a padding bottom to fix that :( But thanks for the trick !

rodrigograca31 commented 8 years ago

I can confirm this issue! I've been using the admob plugin cordova-plugin-admobpro (version: 2.18.0) and it worked fine until I added this plugin.... It went from the bottom (position: AdMob.AD_POSITION.BOTTOM_CENTER) to the top when I added this plugin....

Using overlap: true may work but it's not the best solution.... Because from then on you have to have some padding on your views or content will be overlapped by admob....