search

shramee / starklings-cairo1

An interactive tutorial to get you up and running with Cairo v1 and Starknet
MIT License
450 stars 394 forks source link

bug: LSP crash with starklings, prelude is not a core submodule. #193

Closed N0lanV closed 8 months ago

N0lanV commented 8 months ago

Bug Report

Cairo version: 2.5.3

Current behavior: LSP worker panic with Starklings-cairo1 exercices.

thread 'main' panicked at /cargo/registry/src/index.crates.io-6f17d22bba15001f/cairo-lang-semantic-2.5.3/src/corelib.rs:57:28:
`prelude` is not a core submodule.

Expected behavior: Working like when I create a new project

Steps to reproduce: Install vscode, scarb stable, add cairo 1.0 extension, clone starklings-cairo1 and open the project.

Other information: image

shramee commented 8 months ago

Hi, This seems to originate from your Cairo install. Or you might have another dependency unintentionally named core (been there, done that).

N0lanV commented 8 months ago

Hi :hand: It's a fresh install of Cairo through Scarb and I've not updated any files outside of exercices folder. image

My LSP work with a new Cairo project so the error should be in this project.

But you can close this issue if you can't replicate on your side, no problem :relaxed:

shramee commented 8 months ago

Aah, can you confirm if it still happens with this PR

https://github.com/shramee/starklings-cairo1/pull/188

N0lanV commented 8 months ago

🎉 Omedetou 🎉

Everything works now ! Thanks for your support and work 🤩 image