search

shramov / leaflet-plugins

Plugins for Leaflet library
http://psha.org.ru/b/leaflet-plugins.html
MIT License
722 stars 289 forks source link

Common questions about relese 3.0 #264

Closed h8nor closed 5 years ago

h8nor commented 6 years ago

The Leaflet 1.2 is used at the moment, but there are significant differences with the previous release. I propose to discuss the issues below.

EN: GitHub Pages is not installed in the settings of this repository. I had to create a temporary repository for viewing the work of plugins (there are no problems on the local machine) .

  1. Leaflet 1.2 perfectly loads geojson, but in old mobile browsers for Android does not work (in fact only markers). Are the plugins of this repository built into it?
  2. Browsers like FF57 cut mixed content. I propose to change the protocol on HTTPS in all files as https://github.com/shramov/leaflet-plugins/blob/bd0a4bfa617b27d115001053475da51ca19f99c6/examples/gpx.html#L4-L5 https://github.com/shramov/leaflet-plugins/blob/bd0a4bfa617b27d115001053475da51ca19f99c6/examples/gpx.html#L12 https://github.com/shramov/leaflet-plugins/blob/bd0a4bfa617b27d115001053475da51ca19f99c6/examples/gpx.html#L15-L16
  3. Plugins of release 3.0 draw lines through canvas or svg? In the previous release plugins in the old mobile browser for Android are displayed normally (loaded Leaflet 0.7), and in the current there are no lines and no markers.
  4. Is this a problem in the Leaflet and can not fix it already?

RU: В настройках этого хранилища не установлен GitHub Pages. Мне пришлось создать временное хранилище для просмотра работы расширений (на локальной машине проблем нет).

  1. Leaflet 1.2 прекрасно загружает geojson, но в старых мобильных браузерах под Android не работает (по факту только маркеры). Павел, в него встроены ваши расширения?
  2. Современные браузеры (как FF57) режут смешанный контент. Предлагаю изменить в файлах протокол на HTTPS https://github.com/shramov/leaflet-plugins/blob/bd0a4bfa617b27d115001053475da51ca19f99c6/examples/gpx.html#L4-L5 https://github.com/shramov/leaflet-plugins/blob/bd0a4bfa617b27d115001053475da51ca19f99c6/examples/gpx.html#L12 https://github.com/shramov/leaflet-plugins/blob/bd0a4bfa617b27d115001053475da51ca19f99c6/examples/gpx.html#L15-L16
  3. Ваши расширения выпуска 3.0 рисуют линии через canvas или svg? В предыдущем выпуске расширения в старом мобильном браузере под Android отображаются нормально (подключён Leaflet 0.7), а в текущем нет ни линий, ни маркеров.
  4. Проблема в Leaflet и как раньше не будет никогда?
johnd0e commented 5 years ago

EN: GitHub Pages is not installed in the settings of this repository. I had to create a temporary repository for viewing the work of plugins (there are no problems on the local machine) .

You are right, it'd be convenient to setup gh-pages. Do you want to help with it?

1. Leaflet 1.2 perfectly loads geojson, but in old mobile browsers for Android does not work (in fact only markers). Are the plugins of this repository built into it?

No.

2. Browsers like FF57 cut mixed content. I propose to change the protocol on HTTPS in all files

Good Idea. Could you make PR for this?

3. Plugins of release 3.0 draw lines through canvas or svg?

Please specify what exact plugins do you mean, and show sample code that leads to mentioned issues.

4. Is this a problem in the Leaflet and can not fix it already?

It's hard to say without knowing what exact issues do you have. AFAIK, all the plugins in this repo should work with latest repo. But not sure about ancient Android versions.

brunob commented 5 years ago

Point 2 fixed ;)

johnd0e commented 5 years ago

Point 2 fixed ;)

Only in some examples.

BTW, I found that deferred.html need to be fixed for current L.Yandex.

Fixed in #292

brunob commented 5 years ago

Can we close tis issue now ?

johnd0e commented 5 years ago

Yes