shramov / leaflet-plugins

Plugins for Leaflet library
http://psha.org.ru/b/leaflet-plugins.html
MIT License
722 stars 289 forks source link

L.BingLayer: fixes / updates / refactoring #288

Closed johnd0e closed 5 years ago

johnd0e commented 5 years ago

Options:

Constructor:

Misc updates and refactoring


This change is Reviewable

johnd0e commented 5 years ago

@brunob

I've finished all planning changes here. Please check and merge, if you are interested in L.BingLayer. If not - just tell me, and I will setup dedicated repo.

brunob commented 5 years ago

Thx @johnd0e 'im totally intersetd in Bing layer, i'll check this asap :)

About dedicated repo, since many years i'm thinking about put every single script here in a dedicated repo, maybe it's the time to do it for Yandex first. We could do that in a common organization. Maybe @leaflet-extras could be the right place.

johnd0e commented 5 years ago

maybe it's the time to do it for Yandex first.

Ok, I will notify you when I finish with Yandex.

Maybe @leaflet-extras could be the right place.

I like this idea.

johnd0e commented 5 years ago

'Aerial* ' and deprecated imagery sets in fact do not have tiles for high zoom levels. And there is no reliable way to get real maxZoom value via API (we always get 21). So I've just implemented heuristic one (will commit after testing).

johnd0e commented 5 years ago

Ready for review

johnd0e commented 5 years ago

Could this be used for this point ?

Unfortunately docs are wrong here, and we never get error with zoom in range 1..21.

brunob commented 5 years ago

'k, let's merge it :)

johnd0e commented 5 years ago

One more note.

brunob commented 5 years ago

Nice, thx for that work @johnd0e !