search

shramov / leaflet-plugins

Plugins for Leaflet library
http://psha.org.ru/b/leaflet-plugins.html
MIT License
722 stars 289 forks source link

L.BingLayer: fix some edge usage cases #290

Closed johnd0e closed 5 years ago

johnd0e commented 5 years ago

This change is Reviewable

brunob commented 5 years ago

Ready to merge @johnd0e ?

johnd0e commented 5 years ago

I need an advise: applyMaxNativeZoom is not core functionality. May be better to refactor it out into separate addon (like in L.Yandex)?

brunob commented 5 years ago

I don't think it's necessary to put it in separate addon just because it's not a core functionality, but... if you think it will charge memory or make much more requests it would be clever to put it in a separate script.

johnd0e commented 5 years ago

it will charge memory or make much more requests

Nothing like this. But it is sort of custom functionality, based on undocumented features. So that part is just not as stable as core.

johnd0e commented 5 years ago

@brunob Ready to merge

brunob commented 5 years ago

Merged and released, thx !