shravan20 / github-readme-quotes

Dynamic quote generator for your GitHub readmes | Give a poetic touch to readmes
https://github-readme-quotes-returns.vercel.app/
MIT License
275 stars 150 forks source link

Quotes based on Specific Personality #131

Open shravan20 opened 3 years ago

shravan20 commented 3 years ago

Is your feature request related to a problem? Please describe. Create Quotes taken from your favourite personality

Describe the solution you'd like

Describe alternatives you've considered Create a folder, storing JSON file storing all personalities quotes in natural order (Aplhabetical order)

Nahdus commented 3 years ago

would like to take up this issue. Implementation plan: -implement a personality search box -use Axios and Cheerio to crawl Goodreads quote search -pick a random quote from the first page and display it. -If no quote is found, display the warning text "no quote found " under the personality search bar.

If this implementation plan sounds good please let me know.

Nahdus commented 3 years ago

heroku service to get quotes is ready

 axios
  .post('https://qoutescraper.herokuapp.com/quote/author', {
    author: "Mahatma Gandhi"
  })
  .then(quote=> {
    console.log(quote)
  })
//output
//"Prayer is not asking. It is a longing of the soul. It is daily admission of one's weakness. It is better in prayer to
//have a heart without words than words without a heart."

//—
//Mahatma Gandhi'
marceloams commented 3 weeks ago

Hi @shravan20,

I wanted to check if this enhancement is still necessary. If so, I'd appreciate knowing if any progress has been made on it. I'd be interested in picking this up and working on the issue if it's still open.

shravan20 commented 3 weeks ago

@marceloams : This is open to for development, you can feel free to pick this up