shravan20 / github-readme-quotes

Dynamic quote generator for your GitHub readmes | Give a poetic touch to readmes
https://github-readme-quotes-returns.vercel.app/
MIT License
273 stars 150 forks source link

Enhancement: Center quotes #198

Open krakxn opened 2 years ago

krakxn commented 2 years ago

The src content seems to not be symmetrical; consequently, it (quotes card) cannot be centered, even when offset w/ custom height and width.

This problem (centering) can only be fixed by fixing the src content (to be symmetrical)--especially since either align="left" and align="right" seem so unfitting.

Cheers!

Ravina-Deogadkar commented 2 years ago

Can I take this task?

krakxn commented 2 years ago

Elaborate?

shravan20 commented 2 years ago

Could add some images and elaborate it?

krakxn commented 2 years ago

@shravan20 The Heroku instance which is responsible with deploying the application (quotes) is currently down; I will provide images when it's running again.

To elaborate, if the quotes are surrounded w/ <p> tags with align="center" they are, though in the middle, aligned very awkwardly in a way where it is aligned slightly to the left and right.

E.g. for a visual representation, assume it is the GitHub profile README, scenarios with align="" attribute with left, right, and center values.

1: Left and Right

image

2: Center

It is aligned like this in almost every scenario, and looks very awkwardly placed

image

A correct alignment would look like this (which it does not):

image

i.e. perfectly aligned center.


I am assuming that the cause of this can only be attributed to the fact that the src (i.e. the content) itself is of disproportional dimensions or a similar problem w/ the content.

fathomer commented 12 months ago

Good find @krakxn

This issue is still there. Check this sample screenshot from @shravan20's readme. The quote is not centered and left margin is less than the right margin. image

4nshuman commented 1 month ago

hey @shravan20, seems to me that this issue was fixed by the PR from @fathomer. Could you confirm if this issue still needs attention ?