Open t-muthuri opened 7 months ago
@t-muthuri is attempting to deploy a commit to the shravan20's projects Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
github-readme-quotes | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 18, 2024 6:19pm |
github-readme-quotes-returns | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 18, 2024 6:19pm |
This update introduces the new neon
layout alongside minor formatting adjustments to the samuel
layout. These changes aim to enhance design flexibility by adding a fresh layout option and refining existing styling details.
File Path | Change Summary |
---|---|
src/layouts/layout.js |
Added neon layout with style and structure functions; minor indentation changes in samuel layout's style function. |
src/layouts/README.md |
Added information about the new neon layout option. |
🐇✨ In the land of code where changes play,
A rabbit danced with code today.
Neon lights and tweaks so slight,
Transform the view with code so bright.
Let's explore this digital delight! 🌟👀
src/layouts/README.md (4)
Near line 15: Possible spelling mistake found. Context: ...eadme-quotes-bay.vercel.app/quote) - socrates
![Quote](https://github-readme-q... --- Near line 18: Possible spelling mistake found. Context: ....vercel.app/quote?layout=socrates) - churchill
![Quote](https://github-readme-q... --- Near line 21: Possible spelling mistake found. Context: ...uote?layout=churchill&theme=merko) - samuel
![Quote](https://github-readme-q... --- Near line 24: Possible spelling mistake found. Context: ...-bay.vercel.app/quote?layout=samuel) - zues (Note: This layout does not have...
src/layouts/README.md (3)
Line range hint `10-10`: Add a blank line above the heading. Please add a blank line above the "Layouts" heading to improve readability and adhere to Markdown best practices. --- Line range hint `9-9`: Surround fenced code blocks with blank lines. Please ensure that fenced code blocks are surrounded by blank lines to enhance readability and maintain consistency with Markdown formatting standards. --- Line range hint `34-34`: Remove one of the consecutive blank lines. Please remove one of the consecutive blank lines to improve readability and maintain consistency with common Markdown practices.
@t-muthuri: There is some issue with build, can you please check that?
Yes.
@shravan20 I have changed a few lines and it looks alright. All checks seem to pass on my end except the authorization one. Kindly let me know if there are any build issues and if possible, where I should check. Thank you.
@t-muthuri: Can you update the same as part of the document? Add sample link for reference as well for preview.
Good work! 🙌🏻
Note: Build issue is resolved after accepting the deployment authorization
There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black
We should return only the card instead seems like we are creating a div outside the card and returning that div.
@t-muthuri: Can you update the same as part of the document? Add sample link for reference as well for preview.
Good work! 🙌🏻
Yes. Thank you.
Note: Build issue is resolved after accepting the deployment authorization
There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black
We should return only the card instead seems like we are creating a div outside the card and returning that div.
I don't seem to be able to preview it. The message is "Team Access Required. You cannot access this unique deployment URL as you are not a member of the team. You can view the latest version of this branch by requesting access to the up-to-date deployment URL ."
How do I go about it?
Attaching the image for your reference @t-muthuri
Note: Build issue is resolved after accepting the deployment authorization
There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black
We should return only the card instead seems like we are creating a div outside the card and returning that div.
I don't seem to be able to preview it. The message is "Team Access Required. You cannot access this unique deployment URL as you are not a member of the team. You can view the latest version of this branch by requesting access to the up-to-date deployment URL ."
How do I go about it?
Check it in the local system:
@shravan20 I have solved the design bug that was there. The div is now rendering as expected. I have also updated the README.md file to include the new layout.
@t-muthuri: Author name is completely getting skipped, it isn't getting auto-sized. Added a sample for preview
@t-muthuri: Author name is completely getting skipped, it isn't getting auto-sized. Added a sample for preview
@shravan20 I cannot tell what the problem is from my end, because when run locally, it renders the div well. See the images attached below.
@t-muthuri: Kindly reopen this, I would like to take a look at it myself & see if its issue from the deployment end.
Thank you!
@t-muthuri: Kindly reopen this, I would like to take a look at it myself & see if its issue from the deployment end.
Thank you!
@shravan20 Hello, I have reopened the PR. Thank you.
Changes made to src/layouts/layout.js. Added a new layout called neon to the layout.js file.
Summary by CodeRabbit
New Features
neon
layout with distinct styling and structure.Style
samuel
layout style function.