shravan20 / github-readme-quotes

Dynamic quote generator for your GitHub readmes | Give a poetic touch to readmes
https://github-readme-quotes-returns.vercel.app/
MIT License
278 stars 149 forks source link

add: new layout #296

Open t-muthuri opened 7 months ago

t-muthuri commented 7 months ago

neonlayout Changes made to src/layouts/layout.js. Added a new layout called neon to the layout.js file.

Summary by CodeRabbit

vercel[bot] commented 7 months ago

@t-muthuri is attempting to deploy a commit to the shravan20's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-readme-quotes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 6:19pm
github-readme-quotes-returns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 6:19pm
coderabbitai[bot] commented 7 months ago

Walkthrough

This update introduces the new neon layout alongside minor formatting adjustments to the samuel layout. These changes aim to enhance design flexibility by adding a fresh layout option and refining existing styling details.

Changes

File Path Change Summary
src/layouts/layout.js Added neon layout with style and structure functions; minor indentation changes in samuel layout's style function.
src/layouts/README.md Added information about the new neon layout option.

🐇✨ In the land of code where changes play,
A rabbit danced with code today.
Neon lights and tweaks so slight,
Transform the view with code so bright.
Let's explore this digital delight! 🌟👀


Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between bf8468c30376d14293aba1db0ab009d4acd3bcd4 and 47681938fba1de13292ee1fdccc86bc32d19e5f7.
Files selected for processing (1) * src/layouts/README.md (1 hunks)
Additional Context Used
LanguageTool (4)
src/layouts/README.md (4)
Near line 15: Possible spelling mistake found. Context: ...eadme-quotes-bay.vercel.app/quote) - socrates
![Quote](https://github-readme-q... --- Near line 18: Possible spelling mistake found. Context: ....vercel.app/quote?layout=socrates) - churchill
![Quote](https://github-readme-q... --- Near line 21: Possible spelling mistake found. Context: ...uote?layout=churchill&theme=merko) - samuel
![Quote](https://github-readme-q... --- Near line 24: Possible spelling mistake found. Context: ...-bay.vercel.app/quote?layout=samuel) - zues (Note: This layout does not have...
Additional comments not posted (3)
src/layouts/README.md (3)
Line range hint `10-10`: Add a blank line above the heading. Please add a blank line above the "Layouts" heading to improve readability and adhere to Markdown best practices. --- Line range hint `9-9`: Surround fenced code blocks with blank lines. Please ensure that fenced code blocks are surrounded by blank lines to enhance readability and maintain consistency with Markdown formatting standards. --- Line range hint `34-34`: Remove one of the consecutive blank lines. Please remove one of the consecutive blank lines to improve readability and maintain consistency with common Markdown practices.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
t-muthuri commented 7 months ago

@t-muthuri: There is some issue with build, can you please check that?

Yes.

t-muthuri commented 7 months ago

@shravan20 I have changed a few lines and it looks alright. All checks seem to pass on my end except the authorization one. Kindly let me know if there are any build issues and if possible, where I should check. Thank you.

shravan20 commented 7 months ago

@t-muthuri: Can you update the same as part of the document? Add sample link for reference as well for preview.

Good work! 🙌🏻

shravan20 commented 7 months ago

Note: Build issue is resolved after accepting the deployment authorization

There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

We should return only the card instead seems like we are creating a div outside the card and returning that div.

t-muthuri commented 7 months ago

@t-muthuri: Can you update the same as part of the document? Add sample link for reference as well for preview.

Good work! 🙌🏻

Yes. Thank you.

t-muthuri commented 7 months ago

Note: Build issue is resolved after accepting the deployment authorization

There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

We should return only the card instead seems like we are creating a div outside the card and returning that div.

I don't seem to be able to preview it. The message is "Team Access Required. You cannot access this unique deployment URL as you are not a member of the team. You can view the latest version of this branch by requesting access to the up-to-date deployment URL ."

How do I go about it?

shravan20 commented 7 months ago

Screenshot_2024-04-18-01-51-56-31_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Attaching the image for your reference @t-muthuri

shravan20 commented 7 months ago

Note: Build issue is resolved after accepting the deployment authorization

There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

We should return only the card instead seems like we are creating a div outside the card and returning that div.

I don't seem to be able to preview it. The message is "Team Access Required. You cannot access this unique deployment URL as you are not a member of the team. You can view the latest version of this branch by requesting access to the up-to-date deployment URL ."

How do I go about it?

Check it in the local system:

https://localhost:3000/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

t-muthuri commented 7 months ago

@shravan20 I have solved the design bug that was there. The div is now rendering as expected. I have also updated the README.md file to include the new layout.

shravan20 commented 7 months ago

@t-muthuri: Author name is completely getting skipped, it isn't getting auto-sized. Added a sample for preview

Screenshot 2024-04-18 at 11 50 20 PM
t-muthuri commented 7 months ago

@t-muthuri: Author name is completely getting skipped, it isn't getting auto-sized. Added a sample for preview

Screenshot 2024-04-18 at 11 50 20 PM

@shravan20 I cannot tell what the problem is from my end, because when run locally, it renders the div well. See the images attached below. Screenshot from 2024-04-18 22-05-57 Screenshot from 2024-04-18 22-07-21

shravan20 commented 7 months ago

@t-muthuri: Kindly reopen this, I would like to take a look at it myself & see if its issue from the deployment end.

Thank you!

t-muthuri commented 7 months ago

@t-muthuri: Kindly reopen this, I would like to take a look at it myself & see if its issue from the deployment end.

Thank you!

@shravan20 Hello, I have reopened the PR. Thank you.