search

shred86 / Ortho4XP

A scenery generator for the X-Plane flight simulator
18 stars 3 forks source link

Bug: install_mac.sh not found #27

Closed scriptPilot closed 4 months ago

scriptPilot commented 4 months ago

Thanks for your efforts to maintain Ortho4XP!

I would like to install on MacOS, but after installing Homebrew, I get the following issue, probably because the install_mac.sh file is not part of the downloaded full installation zip.

Screenshot:

Bildschirmfoto 2024-06-29 um 09 45 48
scriptPilot commented 4 months ago

When I manually download and add the file to the _internal folder, I get the following error:

Error!

install_mac.sh must be located in the main Ortho4XP directory.

When I move the file to the Ortho4XP_Data folder I get the same error message.

scriptPilot commented 4 months ago

Looking into the code I think the root cause are missing files in the downloaded zip. Adding the following files manually to the _insternal folder is solving the issue for me:

Bildschirmfoto 2024-06-29 um 09 57 12
shred86 commented 4 months ago

If you're trying to setup Ortho4XP "manually" (i.e. not use the bundled version), you should be cloning this repository, not downloading the bundled version.

The installation instructions are broken up into two sections, the Recommended setup, which is the bundled version that doesn't require using install_mac.sh, and the Manual setup, which is where you would use install_mac.sh.

So the first question is, do you want to use the bundled version? If so, follow the steps in the Recommended setup (you don't need to do anything under the manual setup).

If you're trying to do the manual setup, follow those steps only (you don't do anything under the recommended setup).

If there's a way I can make that more clear in the installation instructions, let me know. Maybe adding something to the first paragraph that explains there's two ways to setup Ortho4XP?

Edit: I just updated the installation instructions with some verbiage to hopefully make this more clear.

scriptPilot commented 4 months ago

Ah perfect, thanks for your detailed response. It works now like a charm on MacOS via MacBook M1 :-)