shred86 / Ortho4XP

A scenery generator for the X-Plane flight simulator
18 stars 3 forks source link

Add zoom level asterisk, erase cached data feedback and fix symlink bug #7

Closed shred86 closed 5 months ago

shred86 commented 5 months ago

The following changes are made with this pull request:

Features:

Bug Fixes:

zoom-level-asterik

@w8sl I think I saw you mention on the official repo that the progressive_zl branch had some similar feature. I'd be curious to get your feedback if this is something similar.

w8sl commented 5 months ago

Nice feature! No, this one was not present in progressive_zl. I have 2 versions of working Progressive_zl on my fork. It is relatively easy to do PyInstaller mod on 1.40. I have uploaded testing version to my dev branch.

shred86 commented 5 months ago

Interestingly, this feature highlighted a strange bug I can't seem to replicate. I noticed a handful of my tiles was indicating it had custom zones but I never setup any for that tile. Checking the tile config, I can see a long list of entries for zone_list that were in a completely different area and the coordinates for that tile didn't have any custom zones. These were tiles that were built with the original version of Ortho4XP, so I'm pretty confident it's nothing that was introduced with any changes I've made. Even after deleting the tile and recreating it, the same zone_list would show up. I tried it on a clean install and it was not happening, so it's like something was cached that was causing issues. I ended up resolving it by deleting the tile of the coordinates of zone_list and the problematic tile, rebuilt them and now it's empty as I would expect.

Very strange but something I'll be keeping an eye on to see if I can replicate it so we can fix it.

shred86 commented 5 months ago

Found a small issue with symlinks when you use the "Tiles (whole)" delete option, so I went ahead and fixed it as well as another small typo I found. Updated the original title and post. I want to keep PRs focused on one thing at a time to make it easier to review so I'm already breaking my own rule.