Too many requirements + Other

shreesha345 / AI-short-creator

AI-short-creator is an AI-powered tool that turns long videos into short clips. It works best for videos with multiple speakers and topics, such as interviews and documentaries. AI-short-creator finds the most engaging parts of the video, adds captions and transitions, and makes the clips ready for social media.

MIT License

96 stars 15 forks source link

Too many requirements + Other #1

Open dieperdev opened 5 months ago

dieperdev commented 5 months ago

Requirements issue: Your requirements.txt file looks like it has a lot of requirements that aren’t necessary for the project. I’ve looked through all the files and I can confirm there isn’t 200 lines of imports. You may want to check the dependencies again.

Other thoughts:

Rather than using a ton of os.system statements in main.py, you could import the functions and use the code that would be run there.
Put your __pycache__ folder in your .gitignore file.
Place other files (if they’re necessary) displayed in your README file into a separate folder to prevent confusion. Otherwise place these files in your .gitignore too.

shreesha345 commented 5 months ago

thank you for opening a issue

shreesha345 commented 5 months ago

I would look into the requirements and the issue what you have said and I would update it. currently I am working on something else and I need time for that so I would appreciate if your could do a pull request for those changes.

dieperdev commented 5 months ago

@shreesha345 It seems like you have a few files in a location that isn't accessible through the program. Are they supposed to be added? These include the following:

D:\AI-video-maker\Final work\caption\src\Root.tsx
D:\AI-video-maker\Final work\output\best_video_2.mp4
D:\AI-video-maker\final work\subtitles.srt
and the output directory D:\AI-video-maker\final work\raw_video

shreesha345 commented 5 months ago

I have done some Mistake in the path I feel

shreesha345 commented 5 months ago

I am still a beginner in python programming so I would appreciate if you could help me to fix these

dieperdev commented 4 months ago

Sorry for the delay, but are the rest of the files listed above in any way related to the program?

shreesha345 commented 4 months ago

Yes it is uses but you just replace it with these: D:\AI-video-maker\caption\src\Root.tsx D:\AI-video-maker\output\best_video_2.mp4 D:\AI-video-maker\subtitles.srt D:\AI-video-maker\raw_video

dieperdev commented 2 months ago

I think you should upload those files to the repo then.

shreesha345 commented 1 week ago

@dieperdev if you try running this it might fix it. AI-short-creator\caption\src\Root.tsx AI-short-creator\output\ D:\AI-short-creator\subtitles.srt D:\AI-short-creator\raw_video