shreifelagamy / vscode-pestphp

Vscode package to support pestphp framework
MIT License
4 stars 0 forks source link

Test result panel not showing correct output #1

Closed chedaroo closed 2 months ago

chedaroo commented 2 months ago

Expected Behaviour

Passing tests are rendered green in Testing Explorer and Test Results panel

Current Behaviour

Some are and some aren't, but they do all pass. When I run test with pest CLI in terminal all pass and are rendered correctly.

Screenshot 2024-07-02 at 11 50 52
chedaroo commented 2 months ago

Also, kudos on the project 🥇 !!!

shreifelagamy commented 2 months ago

@chedaroo Will check it and try to fix soon, appreciate your support 🙏

chedaroo commented 2 months ago

No prob's, flagging stuff is the easy bit.

It appears to be happening when chaining methods like 'with' and also with 'dataset' methods.

You can reproduce with the following tests:


// Fine
it('is true', function () {
    expect(true)->toBe(true);
});

// No output
it('is true with', function (bool $bool) {
    expect($bool)
        ->toBe(true);
})->with([true, false]);

// Output but incorrect
it('is true with a dataset', function (bool $bool) {
    expect($bool)
        ->toBe(true);
})->with('data');

dataset('data', [true, false]);
Screenshot 2024-07-02 at 12 23 17
shreifelagamy commented 2 months ago

@chedaroo datasets are now supported in v1.1.0, Please check it and let me know if you are facing any issues

I will close this one, but feel free to open new ones if you faced any issues.

don't forget to stare and rate the extension 🙏 👍