search

shresthagrawal / learnp2p

https://learnp2p.org
https://jslibp2p-chat-tutorial.vercel.app
MIT License
26 stars 6 forks source link

Refactor all the code to latest version of js-libp2p #1

Open shresthagrawal opened 4 years ago

prateekreddy commented 4 years ago

I have taken this up and refactoring the code using js-libp2p v0.27.4.

shresthagrawal commented 4 years ago

@prateekreddy awesome! Looking forward for your PR!

prateekreddy commented 4 years ago

@shresthagrawal In chapter 6, currently start and stop events are being used to subscribe and unsubscribe from he pubsub. But in the latest version these events are not present anymore. I was wondering if you would want to structure it in a different way. I have upgraded the libp2p version for the first 5 chapters.

shresthagrawal commented 4 years ago

@prateekreddy yaah sure go for it. I can see in your branch that you have structured it such that everything which was previously under start event callback is now under the below the await libp2p.start().

Kudos for you progress! Nice work Can you create a PR of the your work with WIP in description. It's easier to track progress if the issue for everyone who checks out the repo.

acolytec3 commented 3 years ago

Will be fixed by #11