shreya024 / MemoriesApp

A full stack MERN Application which performs CRUD operations,has ability to search and renders posts using pagination
https://memoriesmernshreya.netlify.app/
17 stars 30 forks source link

Implemented Log/Sign up functionality #61

Closed KARTIK-RAINA5802 closed 2 years ago

KARTIK-RAINA5802 commented 2 years ago

Things I have done :-

1) created sign up page 2) added user model for storing user data in mongoDB 3) Added passport.js for authentication stuff. 4) I have commented mongoDB part.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
memories-app ✅ Ready (Inspect) Visit Preview Aug 14, 2022 at 8:04AM (UTC)
memories-app-server ✅ Ready (Inspect) Visit Preview Aug 14, 2022 at 8:04AM (UTC)
gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 873f26e926392da19c945b687ea674f07f26d7d9 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/873f26e926392da19c945b687ea674f07f26d7d9#diff-0861d6d6b50d7d695344bf2d86d6e5e6R18) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 873f26e926392da19c945b687ea674f07f26d7d9 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/873f26e926392da19c945b687ea674f07f26d7d9#diff-0861d6d6b50d7d695344bf2d86d6e5e6L21) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | cd2ca459a1877de69aee0c9089974dc299eb7e94 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/cd2ca459a1877de69aee0c9089974dc299eb7e94#diff-0861d6d6b50d7d695344bf2d86d6e5e6R28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | cd2ca459a1877de69aee0c9089974dc299eb7e94 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/cd2ca459a1877de69aee0c9089974dc299eb7e94#diff-0861d6d6b50d7d695344bf2d86d6e5e6L28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 916d909fb5f80eb77d5c4c87df6786aaad04ab83 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/916d909fb5f80eb77d5c4c87df6786aaad04ab83#diff-0861d6d6b50d7d695344bf2d86d6e5e6R28) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/mongo_uri#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

shreya024 commented 2 years ago

Okay no need to close the PR.Will review it soon

shreya024 commented 2 years ago

@KARTIK-RAINA5802 Resolve the conflicts