search

shreya024 / MemoriesApp

A full stack MERN Application which performs CRUD operations,has ability to search and renders posts using pagination
https://memoriesmernshreya.netlify.app/
17 stars 30 forks source link

Implemented Login/Sign Up page #64

Closed KARTIK-RAINA5802 closed 2 years ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
memories-app ❌ Failed (Inspect) Aug 17, 2022 at 11:14AM (UTC)
memories-app-server ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 11:14AM (UTC)
gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 873f26e926392da19c945b687ea674f07f26d7d9 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/873f26e926392da19c945b687ea674f07f26d7d9#diff-0861d6d6b50d7d695344bf2d86d6e5e6R18) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 873f26e926392da19c945b687ea674f07f26d7d9 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/873f26e926392da19c945b687ea674f07f26d7d9#diff-0861d6d6b50d7d695344bf2d86d6e5e6L21) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | cd2ca459a1877de69aee0c9089974dc299eb7e94 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/cd2ca459a1877de69aee0c9089974dc299eb7e94#diff-0861d6d6b50d7d695344bf2d86d6e5e6R28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | cd2ca459a1877de69aee0c9089974dc299eb7e94 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/cd2ca459a1877de69aee0c9089974dc299eb7e94#diff-0861d6d6b50d7d695344bf2d86d6e5e6L28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | 916d909fb5f80eb77d5c4c87df6786aaad04ab83 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/916d909fb5f80eb77d5c4c87df6786aaad04ab83#diff-0861d6d6b50d7d695344bf2d86d6e5e6R28) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/mongo_uri#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

KARTIK-RAINA5802 commented 2 years ago

Ok, I found out that there were some errors due to which deployment failed and I solved those errors and it's working fine now on my system but GitGuardian is giving some errors related to MongoDB credentials which I am not able to solve. Can anyone please help with this issue?

And yes I have resolved merge conflicts and did npm I also before pushing.

shreya024 commented 2 years ago

Ok, I found out that there were some errors due to which deployment failed and I solved those errors and it's working fine now on my system but GitGuardian is giving some errors related to MongoDB credentials which I am not able to solve. Can anyone please help with this issue?

And yes I have resolved merge conflicts and did npm I also before pushing.

Great work on resolving the merge conflicts.Don't worry about the MongoDB credentials thing but the client side deployment is failing. image

KARTIK-RAINA5802 commented 2 years ago

Yes I worked on that issue and solved the errors and it started working. So may I push the changes and create a new PR ?

shreya024 commented 2 years ago

Yes I worked on that issue and solved the errors and it started working. So may I push the changes and create a new PR ?

Just push the changes,it'll reflect here only.No need to make a new PR

KARTIK-RAINA5802 commented 2 years ago

Can you send me vercel error because I am not able to see any error on my local system and it's working fine.
I also connected it to my MongoDB compass to check whether login/signup is working or not and it was working.

Screenshot (1381)

KARTIK-RAINA5802 commented 2 years ago

and I also tried to check the vercel details but it's showing 404 page not found.

shreya024 commented 2 years ago

and I also tried to check the vercel details but it's showing 404 page not found.

This is the vercel error image

KARTIK-RAINA5802 commented 2 years ago

Can anyone help me with this issue? I am not able to find out errors locally which is making it more difficult for me to figure out what's going wrong.

And earlier I closed my PR which passed the two checks and then I just pulled the changes and created this new PR and it's not able to pass client-side deployment. I don't know what happened.

shreya024 commented 2 years ago

Can anyone help me with this issue? I am not able to find out errors locally which is making it more difficult for me to figure out what's going wrong.

And earlier I closed my PR which passed the two checks and then I just pulled the changes and created this new PR and it's not able to pass client-side deployment. I don't know what happened.

You can tag the Project Mentors and fellow contributors in discord for help.You could also try deploying your branch on your vercel to figure out the error :)

prakhar728 commented 2 years ago

Can anyone help me with this issue? I am not able to find out errors locally which is making it more difficult for me to figure out what's going wrong.

And earlier I closed my PR which passed the two checks and then I just pulled the changes and created this new PR and it's not able to pass client-side deployment. I don't know what happened.

Okay I am not sure. But did you add .env file and Environment variables on the frontend? With React you need to name the variables as REACT_APP_YOUR_VARIABLE.

  1. Try the npm run build command in your localhost and see if it's working.
KARTIK-RAINA5802 commented 2 years ago

I guess It is build successfully right ?

image

KARTIK-RAINA5802 commented 2 years ago

And I am also getting merge conflicts should I resolve them first?

shreya024 commented 2 years ago

And I am also getting merge conflicts should I resolve them first?

Yes

shreya024 commented 2 years ago

@KARTIK-RAINA5802 Resolve the conflicts and complete the deployment fast so we can merge.Else this issue will be up for reassignment

soumali28 commented 2 years ago

@KARTIK-RAINA5802 any updates?? please resolve the conflicts so that we can merge the pr

KARTIK-RAINA5802 commented 2 years ago

I actually did cleared the merge conflicts but there are still many errors coming and I am not able to solve them because I have just started react and also not getting the the time due to exams and college work.

But I really tried my best to implement this functionality but it didn't work out. This was my first open source experience and I did learned a lot from it but I feel sad as I couldn't contribute.

Thank you for giving me a chance to participate and sorry as I couldn't complete it.

Please unassign me from this issue.

On Wed, 21 Sep 2022, 19:37 Soumali Gorai, @.***> wrote:

@KARTIK-RAINA5802 https://github.com/KARTIK-RAINA5802 any updates?? please resolve the conflicts so that we can merge the pr

— Reply to this email directly, view it on GitHub https://github.com/shreya024/MemoriesApp/pull/64#issuecomment-1253765580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5ZTSYA3DPKAZRN2BL5A4DV7MJDLANCNFSM56VG64RQ . You are receiving this because you were mentioned.Message ID: @.***>

fykaa commented 2 years ago

Thanks a lot for your contributions @KARTIK-RAINA5802 . We are happy that you tried. Unassigning you for now, you could still work on this issue later, All the best!