shreya024 / MemoriesApp

A full stack MERN Application which performs CRUD operations,has ability to search and renders posts using pagination
https://memoriesmernshreya.netlify.app/
17 stars 31 forks source link

Dark Mode Implementation #17 Added toggle button in footer and css for light theme #72

Closed mridulpal019 closed 2 years ago

mridulpal019 commented 2 years ago

Screenshot (107) Screenshot (108)

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
memories-app ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 11:41AM (UTC)
memories-app-server ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 11:41AM (UTC)
gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | MongoDB Credentials | fcb88a54ae7ab0bdbef9b0472be2dfcf7e209ec3 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/fcb88a54ae7ab0bdbef9b0472be2dfcf7e209ec3#diff-0861d6d6b50d7d695344bf2d86d6e5e6L20) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/mongo_uri#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

shreya024 commented 2 years ago

@mridulpal019 change css of login and loading pages as well and give a different bg.png for the background in light theme

mridulpal019 commented 2 years ago

@shreya024 done the said changes.

shreya024 commented 2 years ago

@shreya024 done the said changes.

LGTM! add the change theme button in those two pages as well

mridulpal019 commented 2 years ago

@shreya024 done the said changes.

LGTM! add the change theme button in those two pages as well

@shreya024 where should I place the button in login page.... in the upper part?

shreya024 commented 2 years ago

@shreya024 done the said changes.

LGTM! add the change theme button in those two pages as well

@shreya024 where should I place the button in login page.... in the upper part?

Sure in the top right corner