search

shreya024 / MemoriesApp

A full stack MERN Application which performs CRUD operations,has ability to search and renders posts using pagination
https://memoriesmernshreya.netlify.app/
17 stars 31 forks source link

Fix Issue: #46 Posts UI improvement #74

Closed SahilDahekar closed 2 years ago

SahilDahekar commented 2 years ago
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
memories-app ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 10:48AM (UTC)
memories-app-server ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 10:48AM (UTC)
gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=51622527) | MongoDB Credentials | ca70e773bc8334440657a6780cd12db91bffd458 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/ca70e773bc8334440657a6780cd12db91bffd458#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=51622528) | MongoDB Credentials | ca70e773bc8334440657a6780cd12db91bffd458 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/ca70e773bc8334440657a6780cd12db91bffd458#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79R18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=51622529) | MongoDB Credentials | e36d7516253d6a3d98d9133b562571e42b378c79 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/e36d7516253d6a3d98d9133b562571e42b378c79#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=51622530) | MongoDB Credentials | e36d7516253d6a3d98d9133b562571e42b378c79 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/e36d7516253d6a3d98d9133b562571e42b378c79#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79R18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=52092181) | MongoDB Credentials | f14866ad47c631baa5c4a4f34e1c462e02db9507 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/f14866ad47c631baa5c4a4f34e1c462e02db9507#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=52092182) | MongoDB Credentials | f14866ad47c631baa5c4a4f34e1c462e02db9507 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/f14866ad47c631baa5c4a4f34e1c462e02db9507#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79R18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=51890432) | MongoDB Credentials | 1be62399aae8edd31da432cffb86ce5c92b0f8e6 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/1be62399aae8edd31da432cffb86ce5c92b0f8e6#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=51890433) | MongoDB Credentials | 1be62399aae8edd31da432cffb86ce5c92b0f8e6 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/1be62399aae8edd31da432cffb86ce5c92b0f8e6#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79R18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=52092184) | MongoDB Credentials | 587e40372da93113dd4d1e72368e70a6400476b3 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/587e40372da93113dd4d1e72368e70a6400476b3#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=52092186) | MongoDB Credentials | 905fcbb51724cc5a8fccaf76223d3d26a19de3ab | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/905fcbb51724cc5a8fccaf76223d3d26a19de3ab#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=52882656) | MongoDB Credentials | e1d0d9c75d6f3969662cf2d5b7bf90c50ed4fcc7 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/e1d0d9c75d6f3969662cf2d5b7bf90c50ed4fcc7#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) | | [1431999](https://dashboard.gitguardian.com/incidents/1431999?occurrence=53713015) | MongoDB Credentials | 2c771b161f010f69945111095248047cc278d793 | server/index.js | [View secret](https://github.com/shreya024/MemoriesApp/commit/2c771b161f010f69945111095248047cc278d793#diff-bcb729747c92e72c12e4590f736a334041a572c429756da8af60b6ab89c6be79L18) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/mongo_uri#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

shreya024 commented 2 years ago
  • Made the post cards Responsive.
  • Added glassmorphism to the posts cards.
  • Added animation on load to the cards.

@SahilDahekar Great! Add some ss or gif of the same

SahilDahekar commented 2 years ago

Here are some screen shots and a video of the same

Screenshot 2022-09-10 132640

Memories-App.webm

SahilDahekar commented 2 years ago

@shreya024 @Debdeep1 Also i have a doubt regarding this PR i made has 43 commits i dont know why i just made 4 commit for my changes to the post. So should i create a new PR for let this be

shreya024 commented 2 years ago

@shreya024 @Debdeep1 Also i have a doubt regarding this PR i made has 43 commits i dont know why i just made 4 commit for my changes to the post. So should i create a new PR for let this be

I think it's because u r trying to merge into main.Please make a new PR to the SSOC branch.Everything else LGTM!