search

shreyashsaitwal / rush-cli

:zap: A new and improved way of building MIT AI2 extensions.
GNU General Public License v3.0
46 stars 25 forks source link

Error if contain white space in user profile - windows #30

Closed jerinjacob1999 closed 2 years ago

jerinjacob1999 commented 2 years ago

Describe the bug Installation and build failure on windows if user folder contain space

My Pc user folder name is Jerin Jacob

Screenshots image

I installed rush manually, but for building extension rush-cli still need Appdata folder.

It would be nice to have a option to manually choose installation path

Desktop

https://github.com/jerinjacob1999/rush-cli

shreyashsaitwal commented 2 years ago

Installation and build failure on windows if user folder contain space

Thanks for reporting. Putting classesDir.path (here) inside quotes while passing it to javac should solve this. I think there exist similar bugs in other parts of CLI caused because of passing file paths to executables without quotes. Would you like to put in a PR to fix this?

It would be nice to have a option to manually choose installation path

Agreed, having the ability to change the path to the data directory would be great. This will especially be helpful during development. I like the idea of storing the data-dir path in an environment variable as you implemented in your fork. Would you like to put in a PR for this as well?

shreyashsaitwal commented 2 years ago

Fixed by 01d7d642e6b144fe3c3a5509e2e5c9bd5ee94569.