search

shreyasminocha / regex-for-regular-folk

🔍💪 Regular Expressions for Regular Folk — A visual, example-based introduction to RegEx [BETA]
https://refrf.dev
286 stars 23 forks source link

Navigation #30

Open GaryPWhite opened 2 years ago

GaryPWhite commented 2 years ago

Love your book!

I'm a keyboard person trying to navigate the non-single page, and noticed there wasn't an obvious cue or keyboard pattern to do so. Would you be opposed to me putting in a PR for arrow keys / AD to move been pages? I'm pretty familiar with gatsby and would be thrilled to contribute :)

GaryPWhite commented 2 years ago

also.. might be a separate issue... but noticing that the pages actually reload between next/previous. I'm sure using a would have a little better performance, but there might be a reason you hadn't done that! Let me know, it should be trivial to put both of those in!

shreyasminocha commented 2 years ago

Would you be opposed to me putting in a PR for arrow keys / AD to move been pages? I'm pretty familiar with gatsby and would be thrilled to contribute

That sounds like a good idea. The PR's welcome!

but noticing that the pages actually reload between next/previous. I'm sure using a would have a little better performance

True. That would be cool, but only if there's a way to have it degrade gracefully when javascript is disabled.