search

shreyasminocha / seven-rule-msg

✅ Minimal, opinionated commit message validator
12 stars 1 forks source link

Imperative mood #7

Open mristin opened 4 years ago

mristin commented 4 years ago

Hi @shreyasminocha , I made a similar implementation: https://github.com/mristin/opinionated-commit-message

You can approximate the imperative mood with a set of most frequent English words. It works pretty well in practice.

shreyasminocha commented 4 years ago

Hi.

That's a cool approach, although I'll probably avoid implementing it here—I personally want seven-rule-msg to be relatively lax in this respect. I stand corrected about "[…] checking for imperative tense is non-trivial and error-prone", though. I'll edit that when I get a chance.

Thanks for sharing!

132ikl commented 4 years ago

I think it would be good if seven-rule-msg simply checked for the imperative mood, but does not fail if it is not detected. (Maybe if you're feeling confident you can pass a flag to fail on not-imperative?)