search

shrinerb / shrine

File Attachment toolkit for Ruby applications
https://shrinerb.com
MIT License
3.17k stars 274 forks source link

Make Shrine::DataFile truly top-level citizen #652

Closed ixti closed 1 year ago

ixti commented 1 year ago

Shrine::DataFile is already a top-level citizen, but available only of data uri plugin is loaded. For one use case I need to use DataFile directly when passing it to assign (creating attachment from the raw string), and this will allow do just that.

janko commented 1 year ago

Could you use StringIO directly for your use case?

ixti commented 1 year ago

@janko yeah, after I've opened PR I just realized that I don't actually need DataIO or DataFile :D Sorry for the noize