shrinerb / shrine

File Attachment toolkit for Ruby applications
https://shrinerb.com
MIT License
3.18k stars 275 forks source link

Use lower case constants for headers (fixes Rack > 2 applications) #660

Closed davidalejandroaguilar closed 6 months ago

davidalejandroaguilar commented 1 year ago

On Rack 3 https://github.com/rack/rack/issues/1592, it was decided to lowercase all response headers. Thus, all logic in the codebase that checks for headers coming from Rack > 2 applications is broken.

This PR:

Note

I'm yet to write some specs for this but wanted to get this draft out for potential discussion.

tomasc commented 7 months ago

see #682

janko commented 6 months ago

Closing in favor of https://github.com/shrinerb/shrine/pull/682.