search

shrinish123 / lets-Upsolve

A web app to assist you with upsolving Coding contests on codeforces practice for the future contests to get better and improve performance ,and also get insights and Analysis of your current performance on codeforces.
https://letsupsolve.netlify.app
5 stars 10 forks source link

Enhanced Table moved to another Component #35

Closed MaYaNkKashyap681 closed 1 year ago

MaYaNkKashyap681 commented 1 year ago

Moved Enhanced Table Into a different file and made it a component.

netlify[bot] commented 1 year ago

Deploy Preview for letsupsolve ready!

Name Link
Latest commit 22028929a70f7f94c38305f13a40352342204150
Latest deploy log https://app.netlify.com/sites/letsupsolve/deploys/63a5c69a49606e0008d8467b
Deploy Preview https://deploy-preview-35--letsupsolve.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

shrinish123 commented 1 year ago

@MaYaNkKashyap681 there are some merge conflicts here right now ,just resolve those and make a commit on this PR

MaYaNkKashyap681 commented 1 year ago

@MaYaNkKashyap681 there are some merge conflicts here right now ,just resolve those and make a commit on this PR

I have not changed not even a single line in this code.

MaYaNkKashyap681 commented 1 year ago

@MaYaNkKashyap681 there are some merge conflicts here right now ,just resolve those and make a commit on this PR

I have not changed not even a single line in the file Analysis.js.

MaYaNkKashyap681 commented 1 year ago

Now is it okay?

shrinish123 commented 1 year ago

Its still showing conflicts in package.lock json file , and without resolving the conflicts even I cannot merge them

shrinish123 commented 1 year ago

@MaYaNkKashyap681 there are some merge conflicts here right now ,just resolve those and make a commit on this PR

I have not changed not even a single line in this code.

Ya you have not changed it ,but some other people who contributed did , and hence a good practice is to work in a separate branch in your local then git pull the current version and then git merge the main branch to the branch you are working upon. From next time, its good to follow this workflow.

MaYaNkKashyap681 commented 1 year ago

Now is it ok?

MaYaNkKashyap681 commented 1 year ago

@MaYaNkKashyap681 there are some merge conflicts here right now ,just resolve those and make a commit on this PR

I have not changed not even a single line in this code.

Ya you have not changed it ,but some other people who contributed did , and hence a good practice is to work in a separate branch in your local then git pull the current version and then git merge the main branch to the branch you are working upon. From next time, its good to follow this workflow.

ya sure

shrinish123 commented 1 year ago

Well I guess its solved ,I ll merge it , Thanks for your contribution

MaYaNkKashyap681 commented 1 year ago

Well I guess its solved ,I ll merge it , Thanks for your contribution

welcome