search

shrinkwrap / descriptors

ShrinkWrap subproject for creating Archive Descriptors
Apache License 2.0
26 stars 30 forks source link

Shrinkdesc 15 #12

Closed DavideD closed 12 years ago

DavideD commented 13 years ago

Hi, My implementation of the descriptor for the MANIFEST.MF I tried to figure out how to do that looking at the other examples.

Let me know what I have to fix.

Cheers, Davide

ALRubinger commented 13 years ago

Thanks for these, Davide. I'll have a look soon as I can.

ALRubinger commented 13 years ago

OK, started in on this. Rebase to current state of master is revealing a mismatch in the current design, where really only Node-based exporters are supported at the moment. So I'm reworking a bit. Thanks for all the legwork; need to investigate more on supporting the backend model - but the API and these tests look great.

DavideD commented 13 years ago

Wow, thanks. In the meanwhile I'm starting to take a look at https://issues.jboss.org/browse/SHRINKWRAP-249

ALRubinger commented 13 years ago

Davide: Take a look at:

https://github.com/ALRubinger/descriptors/tree/SHRINKDESC-15

...where I've rebased this on current master. However, compiling isn't working anymore. Resolve and we can get it upstream?

ALRubinger commented 13 years ago

The above is a merge, not a rebase. Need help rebasing? :)

ALRubinger commented 13 years ago

OK, I pushed again to my tree in branch SHRINKDESC-15. Some notes:

1) Why is org.jboss.shrinkwrap.descriptor.impl.spec.ee.manifest in both the "api" and "impl" modules? 2) Isn't Manifest really more like "spec.se"? JAR Manifests aren't specifically an EE construct.

S, ALR

DavideD commented 13 years ago

When I've created the patch the project was quite different. I just pushed the first package that came into my mind since i's quite easy to change.

"spec.se" seems better. I think I was thinking at an enterprise a web archive when I've created the package.

I've actually already created a working version here: https://github.com/DavideD/descriptors/commits/SHRINKDESC-15

but there are a couple of things about the API that I don't like very much. I'll write another message about it or it's better to write on the developer forum?

DavideD commented 13 years ago

I forgot there was an open pull request about this issue. I didn't mean to commit on this pull request. I was still fixing the API.

I will fix this things.

Sorry.

DavideD commented 12 years ago
ALRubinger commented 12 years ago

Upstream into master: https://github.com/shrinkwrap/descriptors/commit/2bef10298a4c3966238106f29ee2b708559e6c24 Retrofitting into 1.2.0-X branch: https://github.com/shrinkwrap/descriptors/commit/6bd624d515bfa9377a862751ee43bdc17d05ae11