search

shrinkwrap / descriptors

ShrinkWrap subproject for creating Archive Descriptors
Apache License 2.0
26 stars 30 forks source link

Shrinkdesc 54 #32

Closed rbattenfeld closed 12 years ago

rbattenfeld commented 12 years ago

Hi Andrew

The separation into api-javaee, api-jboss, impl-javaee and impl-jboss is done. Additionally, I spent a lot of time for writing static test cases. For half of thedescriptors, I wrote new test cases from scratch, covering every element as defined in the spec. The XmlUnit test framework is really a nice thing. As a example, you can have a look at the ejbjar31 test case in the test module. As I wrote this test case, I was shocked about the complexity of the specification. Good thing, I found only two minor things I had to fix.

The state of the static test cases. For the following descriptors are new, fully covering the spec test cases written: 1) application6Descriptor 2) persistence10Descriptor 3) persistence20Descriptor 4) beans10Descriptor 5) ejbjar31Descriptor

The remaining descriptors are tested by the existing static test cases but these test cases are testing not everything. I will continue with the others.

Let me say that after writing these test cases I have a good feeling about the stability of the generated descriptors.

Thanks Ralf

ALRubinger commented 12 years ago

Hmm, I can't get this one to compile as-is:

https://gist.github.com/1130765

ALRubinger commented 12 years ago

Went upstream as: https://github.com/shrinkwrap/descriptors/commit/c18ff1c2eba0f59276cc4ec6bb13f8230e8c8dbe