search

shrinkwrap / descriptors

ShrinkWrap subproject for creating Archive Descriptors
Apache License 2.0
26 stars 30 forks source link

Rename DescriptorImporter.from(String) to DescriptorImporter.fromString(String) - confusing API #60

Closed ringerc closed 12 years ago

ringerc commented 12 years ago

Prior to this change, it was too easy for the reader to assume that the're importing "from" a file, not the data in the string. See:

https://issues.jboss.org/browse/SHRINKWRAP-400

ALRubinger commented 12 years ago

Thanks for this, Craig.

What's the relationship you note with SHRINKWRAP-399 (which I've moved to SHRINKRES-28)?

ALRubinger commented 12 years ago

Upstream:

https://github.com/shrinkwrap/descriptors/commit/6524d96bdd7bbe0894946a398eb4635d8d538d25

and

https://github.com/shrinkwrap/descriptors/commit/c4a44a2c8622ce092994eaa8a9eaef3586838200