search

shrinkwrap / descriptors

ShrinkWrap subproject for creating Archive Descriptors
Apache License 2.0
26 stars 30 forks source link

[SHRINKDESC-122] Ant task for MetadataParser #66

Closed rbattenfeld closed 12 years ago

rbattenfeld commented 12 years ago

Hi Andrew

The patch sent by Jesper is pretty good. I assume, Jesper has tested it before sending the patch. We have to write test cases for this ant task. Bit I don't know how. I asked Jesper how we can test the task via maven.

That means, this JIRA is not finished but probably ok for a short time.

Regards, Ralf

ALRubinger commented 12 years ago

Awesome; good review. Problem is, nothing can go upstream into the codebase without tests, unless we have a compelling reason to do so. Would you ask Jesper to supply those in some form before it goes up, and if not, justify why we'd put this untested into a release (albeit alpha) for him?

rbattenfeld commented 12 years ago

I agree. Jesper replied with some hints how to test this task. I will try to implemented some test cases because I believe that we have to know how this works... It is then finally open to be used by anyone not only by Jesper.

ALRubinger commented 12 years ago

Perfect. :)

rbattenfeld commented 12 years ago

Hi Andrew, I added test cases for testing the new ant task integration.

ALRubinger commented 12 years ago

Upstream: https://github.com/shrinkwrap/descriptors/commit/67a629e979c463be317bdf3699066de94a954b40