search

shrinkwrap / descriptors

ShrinkWrap subproject for creating Archive Descriptors
Apache License 2.0
26 stars 30 forks source link

[SHRINKDESC-142] Support Java EE 5 Web Descriptor #82

Closed rbattenfeld closed 11 years ago

rbattenfeld commented 11 years ago

I added the web-app 2.5 descriptor and the required jsp 2.1 library to the generation process. I also copied one web-app test class in order to check the descriptor execution. I don't think we need more test cases.

Regards, Ralf

rbattenfeld commented 11 years ago

None of the existing descriptors validate the version. The test case just checks that the entered version is replied. You can define any string value as the version, there is no constraint on any attributes implemented. Except the data type, of course.

SHRINKDESC-127 discusses this (fixed attributes). There are of course thinkable to add constraints but I see lots of issues if we go in this direction.

I see SHRINDESC-130 for this, allowing to validate and to guarantee the correctness of the definition . I don't know why this is not accepted so far. It would be nice to know the reasons for this.

ALRubinger commented 11 years ago

Upstream: https://github.com/shrinkwrap/descriptors/commit/97e245f97a1411dcee803c4e60b4aa87568d44bc

What do you mean by SD-130 "not accepted"? Point me to something I missed?