search

shrinkwrap / descriptors

ShrinkWrap subproject for creating Archive Descriptors
Apache License 2.0
26 stars 30 forks source link

Shrinkdesc 151 #96

Closed rbattenfeld closed 10 years ago

rbattenfeld commented 10 years ago

Hi Andrew

This the PR for the common descriptor features as originally wished by the Forge team. The idea is from George. Cool:-)

I squashed all sub commits into one. Let me know if there are issues with this PR.

Thanks Ralf

gastaldi commented 10 years ago

When is this pull request going to be merged?

ALRubinger commented 10 years ago

I've rebased this atop master and placed it into:

https://github.com/shrinkwrap/descriptors/tree/SHRINKDESC-151

It's huge. :) I've started to dig into all the changes but think we should get our eyes on it and talk it out on the forums before merging into master.

In particular, @gastaldi is this the approach you'd been specifying and had taken w/ Forge? The generated API looks as you'd expect?

gastaldi commented 10 years ago

Hi Andrew, Yes, this is exactly what I expected and takes the same approach (if not better) as I did manually to use in Forge 2.

Em 17/03/2014, às 10:51, Andrew Lee Rubinger notifications@github.com escreveu:

I've rebased this atop master and placed it into:

https://github.com/shrinkwrap/descriptors/tree/SHRINKDESC-151

It's huge. :) I've started to dig into all the changes but think we should get our eyes on it and talk it out on the forums before merging into master.

In particular, @gastaldi is this the approach you'd been specifying and had taken w/ Forge? The generated API looks as you'd expect?

— Reply to this email directly or view it on GitHub.

ALRubinger commented 10 years ago

79a4a3f6986836471709ef11d1ac56e744384a90