search

shripalsoni04 / nativescript-webview-interface

Plugin for bi-directional communication between webView and android/ios
MIT License
89 stars 35 forks source link

Use evaluateJavascript instead of loadUrl for Android where possible #17

Closed surdu closed 6 years ago

surdu commented 7 years ago

Using loadUrl will fail if the event data gets too big. In our case we had to transport some base64 images from photo library and we got errors from chromium complaining about the url size.

This will be used only on api level >= 19, as this is not available under this api level.

Maybe the docs should also be updated to warn of the emit's eventData size limitations for future travelers 😃

surdu commented 7 years ago

Hey @shripalsoni04

Anything that can be improved on this PR? 😃

shripalsoni04 commented 6 years ago

Hi @surdu ,

Thanks a lot for this PR and sorry for extremely late reply. I somehow just missed this PR as I was not getting time to actively look into this project.

I tested the changes with Demo application and it is working perfectly fine 👍

Thanks.

shripalsoni04 commented 6 years ago

FYI, PR is published with nativescript-webview-interface version 1.4.2 on npm.