search

shripalsoni04 / nativescript-webview-interface

Plugin for bi-directional communication between webView and android/ios
MIT License
89 stars 35 forks source link

Make explicit import from tns-core-modules #43

Closed jakobe closed 5 years ago

jakobe commented 5 years ago

In index.d.ts the current import is: import {WebView} from 'ui/web-view'; This creates an implicit dependency in the project consuming the package where tsconfig need to have the following wildcard paths specified:

"compilerOptions": {
        "paths": {
            "*": [
                "./node_modules/tns-core-modules/*",
                "./node_modules/*"
            ],
        }
    },

This can easily be fixed by importing explicitly from tns-core-modules: import {WebView} from 'tns-core-modules/ui/web-view';

MortenGregersen commented 5 years ago

Fixed by #44

kdhrubo commented 5 years ago

@shripalsoni04 pls merge and give a new minor release its breaking after upgrade

shripalsoni04 commented 5 years ago

Thanks a lot @jakobe for the PR and @kdhrubo for a reminder.

I have merged the PR and it is released with version 1.4.3

jakobe commented 5 years ago

You're welcome @shripalsoni04 and thanks for accepting the PR :)