shripalsoni04 / nativescript-webview-interface

Plugin for bi-directional communication between webView and android/ios
MIT License
89 stars 35 forks source link

replaced tns-core-modules by @nativescript/core and added some fixes #56

Closed alexander-mai closed 4 years ago

alexander-mai commented 4 years ago
eltharynd commented 4 years ago

@shripalsoni04 Can you please take this since your repo is the official one on nativescript marketplace? I've verified his changes myself and it fixed this plugin for new nativescript versions

thanks @alexander-mai for taking the time

wendt88 commented 4 years ago

@shripalsoni04 can you please accept this PR to add compatibility to NS7?

Thanks!

shripalsoni04 commented 4 years ago

Sorry, @alexander-mai for taking look at this PR so late. I am actually not working on any nativescript projects since long and was so busy with other stuff.

Though I haven't tested it personally, the changes seem fine to me. So going to merge it.

Thanks a lot for your contributions.

cc @eltharynd , @wendt88

shripalsoni04 commented 4 years ago

Published the changes of this PR with version @1.4.4. Thanks all 🙌