search

shriprem / FWDataViz

Fixed Width Data Visualizer plugin for Notepad++. Turns Notepad++ into Excel for fixed-width data files. Displays cursor position data. Jumps to specific fields. Folding Record Blocks. Extracts Data. Builtin dialogs to configure file-type, record-type & fields; Themes & Colors; and Folding. Handles homogenous, mixed & multi-line records.
GNU General Public License v2.0
37 stars 6 forks source link

[Bug] Theme applied incompletely during switching when they have different number of colors defined #39

Closed trybowski closed 2 years ago

trybowski commented 2 years ago

If you switch between themes which have different number of colors defined (in my case 12 vs 2), then colors in positions which don't exist in one of them are not reapplied, and resulting screen shows either a mixture of two themes or a subset of target theme. It looks that number of colors to be applied is taken from old theme instead of new. Switching to another app and back to N++ fixes this.

  1. Starting with a colorful theme Tango Stripes: image

  2. Going to change theme to Gray: image

  3. I expect this: image

  4. But I get this: image

  5. Then I fix it (see screen as in point 3), and I switch from Gray back to Tango Stripes, and again an error: image

Adding my Themes.ini for reference. Themes.zip

shriprem commented 2 years ago

@trybowski, this is happening because a page render event is not firing after a theme selection change in the drop down. Just click anywhere inside the document pane. The render event will fire, and then you should only see the selected theme colors as per expectation.

Just an FYI, this quirk has been there all along, and did not come about from any of the changes in the past few days. I can fix this tiny bug by merely firing a render event after theme selection change. But I will wait on providing you a build until I get feedback from you from the field style enhancement build. Thank you.

shriprem commented 2 years ago

@trybowski, as mentioned in my latest posting for issue #37, the builds provided there include the fix for the theme rendering issue reported here.

Please try those builds, and feel free to close this issue if you can verify that it has been fixed. Thanks!

trybowski commented 2 years ago

It works now. Thank you.