search

shriram / gradescope-racket

Infrastructure to autograde Racket code on Gradescope
MIT License
17 stars 8 forks source link

Fix type inconsistency #20

Closed wilbowma closed 2 years ago

wilbowma commented 2 years ago

Score is either a string or a number, but I prefer it were consistent

I'm actually not sure about this one, but the inconsistency made implementing my post-processing annoying.

Probably I'd prefer the score to be stored as a number in the hash, and then post-processed to a string separately, perhaps by produce-report/exit. But I'm not sure about the implications of that one.

shriram commented 2 years ago

@jasonhemann Any opinions on this?

jasonhemann commented 2 years ago

@wilbowma , you mean some post processing you are doing outside this lib, yes? I don't see how this affects produce-report/exit.

This change seems okay to me. In principle, I think I too would probably prefer storing as a number in the hash and then later transforming to a string. What kinds of implications are you thinking about?

wilbowma commented 2 years ago

No I post-process in Racket, after getting the results from generate-results/hash.

I’m not sure what the implications would be. I think produce-report/exit is always called on the through the existing interface and could do the conversion without breaking backwards compatibility. But all of its callers should be updated to provide score as a number; are there any callers in grading files people have written? This could create work for users.

jasonhemann commented 2 years ago

Works for me, then.