search

shriya-tiwari / Reciplay_website

A website built using basic HTML, CSS and Javascript for beginner developers to learn basic developing and API calling.
https://reciplay.vercel.app/
4 stars 13 forks source link

Your API key is public #10

Closed cherylli closed 1 year ago

cherylli commented 1 year ago

In js/config

API keys should not be committed to a public repository

SRIMANKS commented 1 year ago

I can work on this but what should I do then instead of putting API in the public repository? can you assign me this?

cherylli commented 1 year ago

I'm not the owner of this repo. I just came to checked it out and saw the API is publicly accessible.

Normally you would put something like API keys in the environment variables or just a file not pushed to github

shriya-tiwari commented 1 year ago

Its fine, if a front end project requires the API key to be publicly accessible for open source contribution, I should not bother making it hidden in .gitignore file. Otherwise it becomes difficult for people to contribute.