search

shriya-tiwari / Reciplay_website

A website built using basic HTML, CSS and Javascript for beginner developers to learn basic developing and API calling.
https://reciplay.vercel.app/
4 stars 13 forks source link

Improve the card design of the dishes #3

Open shriya-tiwari opened 2 years ago

shriya-tiwari commented 2 years ago

The card design displayed is very simple, looking forward to some enhancements in it.

robin6717 commented 2 years ago

Hi, can I give that a try? I would love that!

kind regards,

Robin

shriya-tiwari commented 2 years ago

yup go ahead

robin6717 commented 2 years ago

Hi, thank you. The api does not provide me with cards/recipees. Any idea why? I will look into this later but maybe you can give me a hint..( nothing happens when I submit the ingredients )

robin6717 commented 2 years ago

Maybe this is too difficult for me yet.. I kind of like your design of the cards already.. Can you please unasign me? Im sry to have bothered you. Next time i wll try first before asking to assign me.

shriya-tiwari commented 2 years ago

are you entering the ingredients on the cuisine page, because it wont work there, it can work only for the home page. I had not added the logic in the cuisine page yet, hence the problem. But if you have done it in the home page maybe i could help me if i know what messages you are gettingin your console.

robin6717 commented 2 years ago

yes, i try it on the home page

robin6717 commented 2 years ago

Uncaught TypeError: Cannot read properties of undefined (reading 'push') at HTMLButtonElement.addingredient (index.js:41:20) addingredient @ index.js:41 index.js:105 Uncaught TypeError: Cannot read properties of undefined (reading 'join') at refresh (index.js:105:29) at HTMLButtonElement.onclick (home.html:49:118)

shriya-tiwari commented 2 years ago

You dont need to change anything with the logic, only css and html of the cards, if you still dont want to try, then i will unassign, no problem.

shriya-tiwari commented 2 years ago

Uncaught TypeError: Cannot read properties of undefined (reading 'push') at HTMLButtonElement.addingredient (index.js:41:20) addingredient @ index.js:41 index.js:105 Uncaught TypeError: Cannot read properties of undefined (reading 'join') at refresh (index.js:105:29) at HTMLButtonElement.onclick (home.html:49:118)

Hmmm, this should not happen unless you have made any changes to the code of index.js file.

robin6717 commented 2 years ago

I understand, yes please unassign.. I really like the project tho! It is a great idea and looks great...If i manage to make something may I then send you a screenshot to show it? thank you for your understanding.

robin6717 commented 2 years ago

No I have not made any changes to the js!

robin6717 commented 2 years ago

also the pop method did not work btw.. Uncaught TypeError: Cannot read properties of undefined (reading 'pop') at list.onclick (index.js:31:24)

shriya-tiwari commented 2 years ago

I understand, yes please unassign.. I really like the project tho! It is a great idea and looks great...If i manage to make something may I then send you a screenshot to show it? thank you for your understanding.

No problem, i will unassign you. But if you figure out something be sure to come back and make contributions. This is what open source is about, helping and learning from each other :)

shriya-tiwari commented 2 years ago

also the pop method did not work btw.. Uncaught TypeError: Cannot read properties of undefined (reading 'pop') at list.onclick (index.js:31:24)

I think its happening because the api key is not available. I will do that now.

shriya-tiwari commented 2 years ago

You can again fork the repository and try it if you want, it should work this time.

robin6717 commented 2 years ago

ok I will do that now!

robin6717 commented 2 years ago

Yes it works perfectly now! Thank you, and you are right.. even this was in a way a learning experience for me.. ! I appreciate your kindness, I will try to make a nice contribution to your cool project! have a great day!

robin6717 commented 2 years ago

if you can wait max 2 days to wait for the result I would like to stay assigned !

robin6717 commented 2 years ago

screen

dasashreeya commented 2 years ago

Hey can I work on this issue if it is still open?

shriya-tiwari commented 2 years ago

@robin6717 i cant see many changes in the design of the card, except for the color change. If you can make any more prominent changes, it would be better.

shriya-tiwari commented 2 years ago

Yes you can go ahead @dasashreeya đź‘Ť

dasashreeya commented 2 years ago

Hey, do you want me to make a carousel-type design where you can click on arrows to see the next recipe card?

shriya-tiwari commented 2 years ago

Hey, do you want me to make a carousel-type design where you can click on arrows to see the next recipe card?

Yes that would be really good, if you can do it please go ahead.

dasashreeya commented 2 years ago

Hey can you assign it to someone else? I tried it and I can’t seem to work with APIs

On Sat, 22 Oct 2022 at 13:54, Shriya Tiwari @.***> wrote:

Hey, do you want me to make a carousel-type design where you can click on arrows to see the next recipe card?

Yes that would be really good, if you can do it please go ahead.

— Reply to this email directly, view it on GitHub https://github.com/shriya-tiwari/Reciplay_website/issues/3#issuecomment-1287675310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUQN23X2AIVBGYKZOHJN3H3WEOQE7ANCNFSM6AAAAAARKFSQYI . You are receiving this because you were assigned.Message ID: @.***>

shriya-tiwari commented 2 years ago

Ok no problem, can you share what problem you were facing?