search

shriyaMadan / Youtube-Dashboard

Helps in seeing your channel's stats
MIT License
12 stars 25 forks source link

Improvements needed on Home Page #8

Closed aniketsingh98571 closed 3 years ago

aniketsingh98571 commented 3 years ago

On the home page, it will be good if you can make the contents align vertically and horizontally center by using flexbox On the container, div use this.

Container{ display:flex; justify-content:center; align-items:center; height:80vh }

It will look like everything sorted and it is responsive on all devices.If not I can handle it.

aniketsingh98571 commented 3 years ago

Looking forward to contributing to it as a part of DevScript Winter of Code.

shriyaMadan commented 3 years ago

Kindly look for more improvements

Aarush-Goyal commented 3 years ago

@aniketsingh98571 @shriyaMadan I guess we can just enhance the UI a little bit also would suggest using React js on the frontend

shriyaMadan commented 3 years ago

@aniketsingh98571 @Aarush-Goyal Okay, enhancement is needed in the frontend but take into consideration that this will have the option of viewing own stats and other option of viewing public stats of any channel(which will be done without signing in to Youtube account).

shriyaMadan commented 3 years ago

One major improvement needed rn is the name of the channel should be shown when its result is displayed.

shriyaMadan commented 3 years ago

@aniketsingh98571 you can start working to improve the home page.

aniketsingh98571 commented 3 years ago

Container{ display:flex; justify-content:center; align-items:center; height:80vh }

@shriyaMadan Are you talking about this..?

shriyaMadan commented 3 years ago

No @aniketsingh98571 these won't do any good.

Aarush-Goyal commented 3 years ago

@shriyaMadan I will take care of the dsplay of names on the result page

Aarush-Goyal commented 3 years ago

@shriyaMadan I have handled the issue of adding names in pr #15 pls review it

shriyaMadan commented 3 years ago

@Aarush-Goyal done and dusted!

Sakshi-Jangra commented 3 years ago

Hey, I want to contribute to this project. Kindly assign me some task. Also, is this done using React / Node?

Aarush-Goyal commented 3 years ago

@Sakshi-25 Yes this is made using Node. I will be adding react after some time. If you want to act react you can go forward with that.

Satyam1203 commented 3 years ago

Can I work on the improvement of homepage? I can do it either in ReactJS or just ejs template through node.js. @shriyaMadan @Aarush-Goyal

shriyaMadan commented 3 years ago

yes @Satyam1203, you can work on this issue. The project isn't in React yet, it would be using a framework soon.

Satyam1203 commented 3 years ago

@shriyaMadan, should I make it use ReactJS then?

shriyaMadan commented 3 years ago

yes, you may start working on it, me and @Aarush-Goyal will help.

Sloth-Panda commented 3 years ago

Hey, I can take this issue. please let me know

shriyaMadan commented 3 years ago

@Satyam1203 any updates?

Satyam1203 commented 3 years ago

I'm on it @shriyaMadan. Most probably would drop a PR by tomorrow end.

shriyaMadan commented 3 years ago

I'm on it @shriyaMadan. Most probably would drop a PR by tomorrow end.

@Satyam1203 updates?