search

shriyasshah / shriya2025

https://shriyasshah.github.io/shriya2025/
Apache License 2.0
0 stars 0 forks source link

About | Shriya Shah #2

Open utterances-bot opened 1 month ago

utterances-bot commented 1 month ago

About | Shriya Shah

Class of 2025

https://shriyasshah.github.io/shriya2025/about/

shriyasshah commented 1 month ago

hawk tuah

nulxn commented 1 month ago

bad) images have wrong/weird ratio good) nice colors and lighting bad) missing python notebook & emojis good) did optional assignments (not mario)

JustinQ-DNHS commented 1 month ago

Good work, you did a lot of the assignments and I can tell you are learning. The border-radius on your images tells me that much at least. I think you need to fix the CSS for some of your pages as words are hard to see on some but that is fine. I recommend fixing your aspect ratio for your images. This can be done by looking at the images dimensions and using those for the height and width instead of the custom numbers you used. You can then multiply the numbers by a percentage in order to re-scale it. OR you can use the scale CSS, whichever you prefer. You are also missing quite a few hacks but this is negligible.

abbymanalo commented 1 month ago

Good: -lots of pages, obvious that lots of work and effort was done -customized page/theme Can Improve On: -maybe put your projects somewhere else instead of the top bar, consider making a submenu on your home page or a dropdown menu -need more notebooks and personal pages