search

shroominic / funcchain

⛓️ build cognitive systems, pythonic
https://shroominic.github.io/funcchain/
MIT License
327 stars 22 forks source link

Docstring for get_gguf_model is inaccurate #28

Open ahuang11 opened 9 months ago

ahuang11 commented 9 months ago

I don't think it matches the signature.

get_gguf_model(
    name: str,
    label: str,
    settings: FuncchainSettings,
) -> Path:
    """
    Gather GGUF model from huggingface/TheBloke

    possible input:
    - DiscoLM-mixtral-8x7b-v2-GGUF
    - TheBloke/DiscoLM-mixtral-8x7b-v2
    - discolm-mixtral-8x7b-v2
    ...

    Raises ModelNotFound(name) error in case of no result.
    """
shroominic commented 9 months ago

adding name = name.removeprefix("TheBloke/") should fix it i think or what do you mean?