search

shrpne / vue-inline-svg

Dynamically loads an SVG source and inline <svg> element so you can manipulate the style of it
MIT License
175 stars 21 forks source link

Add http status to data field #30

Closed kdumontnu closed 1 month ago

kdumontnu commented 3 years ago

I'm working on an implementation where it would be very helpful to have the status code of the request response. I think others might find this useful too.

shrpne commented 3 years ago

Maybe it will be more useful to save the whole request object then?

kdumontnu commented 3 years ago

Maybe it will be more useful to save the whole request object then?

Either is fine with me. If you think it's cleaner to save the request object I'm happy to make the change (also don't mind if you want to change it).

Thanks for the library btw.

kdumontnu commented 3 years ago

@shrpne any preference here? Status code is all I need. Might be simplest to just save the status as I have it here.

shrpne commented 3 years ago

Can you please update to save the whole request object and I will be glad to merge it

shrpne commented 1 month ago

completed in #60