vp8_dequant_dc_idct_mmx uses SSE instruction pinsrw

[GoogleCodeExporter]

In vp8_dequant_dc_idct_mmx there's this line:

        pinsrw      mm0,    rcx,  0

In Opera, we've seen crashes from users on machines older than Pentium 3, since 
"pinsrw" is an instruction added in the SSE instruction set.

Original issue reported on code.google.com by philip.j...@gmail.com on 12 Jul 2010 at 9:55

[GoogleCodeExporter]

Here's my fix. I'm a complete newb when it comes to x86 assembly, but this 
seems to do the job in 5 instructions (previously 2).

Original comment by philip.j...@gmail.com on 13 Jul 2010 at 10:44

Attachments:

• 0001-Replace-pinsrw-SSE-with-MMX-instructions.patch

[GoogleCodeExporter]

Is a patch fine or is this supposed to go through the review system somehow?

Original comment by philip.j...@gmail.com on 13 Jul 2010 at 12:54

[GoogleCodeExporter]

Ideally these should be submitted through our Gerrit system, but I put this one 
in the system for you.

https://review.webmproject.org/318

Original comment by jkoles...@google.com on 13 Jul 2010 at 1:42

• Changed state: Accepted

[GoogleCodeExporter]

This will also indirectly address #74.

Original comment by jz...@google.com on 13 Jul 2010 at 4:14

[GoogleCodeExporter]

> This will also indirectly address #74.

I suggest closing #74 immediately as INVALID.

The patch is still not applied, meanwhile this bug has been independently 
discovered, investigated, reported and "fixed" here:

http://sf.net/tracker/index.php?func=detail&aid=3034472&group_id=205275&atid=992
986

No further SSE instructions in MMX decoding code (from that time) discovered. 

Original comment by dos...@gmail.com on 31 Jul 2010 at 5:08

[GoogleCodeExporter]

http://review.webmproject.org/#change,318

Original comment by jkoles...@google.com on 4 Aug 2010 at 1:04

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by albe...@google.com on 8 Mar 2012 at 12:10

• Added labels: Type-Bug
• Removed labels: Type-Defect