search

shshankjain / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vp8_sdk should be relocated to third_party/libvpx #179

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It's an upstream project and technically is not part of webmdshow.  It really 
doesn't belong where it currently resides in the repository.

The point of this is to make the includes sane.  The includes should be moved 
to third_party/libvpx/vpx, while the lib should reside within 
third_party/libvpx.  The former would allow includes to be identical to those 
used elsewhere to pull in the vpx headers (i.e. #include "vpx/blah.h" instead 
of #include "blah.h".

The current setup is especially bothersome with the addition of other upstream 
libs to third_party.

Original issue reported on code.google.com by tomfine...@google.com on 16 Sep 2010 at 11:56

GoogleCodeExporter commented 9 years ago 
When I say vp8_sdk should be relocated I mean the contents of the directory... 
I don't want third_party/libvpx/vp8_sdk to come about.

Original comment by tomfine...@google.com on 16 Sep 2010 at 11:58

GoogleCodeExporter commented 9 years ago 
This commit begins work on the issue:

https://review.webmproject.org/gitweb?p=webmdshow.git;a=commit;h=839efbb220905c7
e5073cef6bb6bc378cad52d1e

It adds the libvpx binaries and includes to third_party/libvpx.  Projects will 
need to be updated to use the new paths, and source file inclusions of libvpx 
.h files should be adjusted (from <x.h> to <vpx/x.h> preferably).

Original comment by tomfine...@google.com on 29 Sep 2010 at 6:52

GoogleCodeExporter commented 9 years ago 
I have modified the mediafoundation projects.

Original comment by matthewj...@google.com on 29 Sep 2010 at 7:28

GoogleCodeExporter commented 9 years ago

Original comment by iss...@webmproject.org on 16 Mar 2011 at 2:51

GoogleCodeExporter commented 9 years ago

Original comment by frkoe...@google.com on 16 Mar 2011 at 2:56

GoogleCodeExporter commented 9 years ago 
This was fixed quite a long while ago... I forgot to close it.  Oops!

Add libvpx to third_party/libvpx:
https://review.webmproject.org/#change,638

Remove the old one/update builds:
https://review.webmproject.org/#change,643

Original comment by tomfine...@google.com on 16 Mar 2011 at 8:23

GoogleCodeExporter commented 9 years ago

Original comment by albe...@google.com on 8 Mar 2012 at 12:10